Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[SFN] Support for State Machine versioning #8894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Aug 17, 2023
Merged

[SFN] Support for State Machine versioning #8894

merged 9 commits into from
Aug 17, 2023

Conversation

MEPalma
Copy link
Contributor

@MEPalma MEPalma commented Aug 11, 2023 •
edited
Loading

Motivation

Adds support for State Machine versioning to version 2 provider #8855

Changes

Introduces State Machine versioning logic. In the provider support is extends to:

  • CreateStateMachine

    • Request
      • publish
        Set to true to publish the first version of the state machine during creation. The default is false.
      • versionDescription
        Sets description about the state machine version.
    • Response
      • stateMachineVersionArn
        If you set publish the (ARN) that identifies the created state machine version

  • DescribeStateMachine

    • Request
      • stateMachineArn
        If you specify a state machine version ARN, this API returns details about that version.
    • Response
      • description
        The description of the state machine version.

  • DeleteStateMachineVersion

    • Request:
      • stateMachineVersionArn

  • ListStateMachineVersions

  • PublishStateMachineVersion

    • Request:
      • revisionId
        Only publish the state machine version if the current state machine's revision ID matches the specified ID.
    • Respone:
      • stateMachineVersionArn

  • StartExecution

    • Request
      • stateMachineArn
    • Response
      — executionArn

  • UpdateStateMachine

    • Request
      • publish
        Specifies whether the state machine version is published. The default is false.
    • Response
      • stateMachineVersionArn
        The ARN of the published state machine version. If publish else null.

  • ListExecutions

    • Request
      • stateMachineArn
        You can also return a list of executions associated with a specific alias or version, by specifying an alias ARN or a version ARN in the stateMachineArn parameter.

Testing

Adds snapshot tests for base scenarios in tests:

  • tests.aws.stepfunctions.v2.test_sfn_api_versioning.TestSnfApiVersioning.test_create_with_publish
  • tests.aws.stepfunctions.v2.test_sfn_api_versioning.TestSnfApiVersioning.test_create_with_version_description_no_publish
  • tests.aws.stepfunctions.v2.test_sfn_api_versioning.TestSnfApiVersioning.test_create_publish_describe_no_version_description
  • tests.aws.stepfunctions.v2.test_sfn_api_versioning.TestSnfApiVersioning.test_create_publish_describe_with_version_description
  • tests.aws.stepfunctions.v2.test_sfn_api_versioning.TestSnfApiVersioning.test_list_delete_version
  • tests.aws.stepfunctions.v2.test_sfn_api_versioning.TestSnfApiVersioning.test_update_state_machine
  • tests.aws.stepfunctions.v2.test_sfn_api_versioning.TestSnfApiVersioning.test_publish_state_machine_version
  • tests.aws.stepfunctions.v2.test_sfn_api_versioning.TestSnfApiVersioning.test_start_version_execution
  • tests.aws.stepfunctions.v2.test_sfn_api_versioning.TestSnfApiVersioning.test_version_ids_between_deletions
  • tests.aws.stepfunctions.v2.test_sfn_api_versioning.TestSnfApiVersioning.test_idempotent_publish
  • tests.aws.stepfunctions.v2.test_sfn_api_versioning.TestSnfApiVersioning.test_empty_revision_with_publish_and_publish_on_creation
  • tests.aws.stepfunctions.v2.test_sfn_api_versioning.TestSnfApiVersioning.test_empty_revision_with_publish_and_no_publish_on_creation

@MEPalma MEPalma added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label Aug 11, 2023
@MEPalma MEPalma added this to the 2.3 milestone Aug 11, 2023
@MEPalma MEPalma self-assigned this Aug 11, 2023
@MEPalma MEPalma linked an issue Aug 11, 2023 that may be closed by this pull request
bug: cannot deploy stepfunctions using terraform aws provider 5.11.0 #8855
Closed
1 task
@github-actions
Copy link

github-actions bot commented Aug 11, 2023 •
edited
Loading

LocalStack Community integration with Pro

       2 files         2 suites   1h 15m 35s ⏱️
2 102 tests 1 659 ✔️ 443 💤 0 ❌
2 103 runs  1 659 ✔️ 444 💤 0 ❌

Results for commit 4adc352.

♻️ This comment has been updated with latest results.

@MEPalma MEPalma marked this pull request as ready for review August 16, 2023 21:27
dominikschubert
dominikschubert approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome to see support for this in the new provider 🚀 🤟

@MEPalma MEPalma merged commit 52fb460 into master Aug 17, 2023
@MEPalma MEPalma deleted the MEP-sfn-versioning branch August 17, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikschubert dominikschubert dominikschubert approved these changes

Assignees

@MEPalma MEPalma

Labels
semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
2.3
Development

Successfully merging this pull request may close these issues.

bug: cannot deploy stepfunctions using terraform aws provider 5.11.0
2 participants
@MEPalma @dominikschubert