Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[SFN] Support for sync:2 #8900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 16, 2023
Merged

[SFN] Support for sync:2 #8900

merged 2 commits into from
Aug 16, 2023

Conversation

MEPalma
Copy link
Contributor

@MEPalma MEPalma commented Aug 12, 2023

Motivation

Adds missing support for StepFunction's sync:2 resource invocations, contributing to the greenification of #8779, which sets StepFunction v2 as default provider.

Changes

  • Cleanup of ResourceArn and Resource objects.
  • Added sync:2 logic to sfn's task resolver.
  • Added sync:2 snapshot test for sfn's task resolver.

@MEPalma MEPalma added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label Aug 12, 2023
@MEPalma MEPalma added this to the 2.3 milestone Aug 12, 2023
@MEPalma MEPalma self-assigned this Aug 12, 2023
@coveralls
Copy link

Coverage Status

coverage: 81.72% (+0.2%) from 81.54% when pulling a37b468 on MEP-sfn-sync2 into 2256615 on master.

@github-actions
Copy link

github-actions bot commented Aug 12, 2023 •
edited
Loading

LocalStack Community integration with Pro

       2 files         2 suites   1h 22m 24s ⏱️
2 090 tests 1 658 ✔️ 432 💤 0 ❌
2 091 runs  1 658 ✔️ 433 💤 0 ❌

Results for commit afe87af.

♻️ This comment has been updated with latest results.

dominikschubert
dominikschubert approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@MEPalma MEPalma merged commit 94e8f38 into master Aug 16, 2023
@MEPalma MEPalma deleted the MEP-sfn-sync2 branch August 16, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikschubert dominikschubert dominikschubert approved these changes

Assignees

@MEPalma MEPalma

Labels
semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
2.3
Development

Successfully merging this pull request may close these issues.
3 participants
@MEPalma @coveralls @dominikschubert