Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[SFN] Support for global Timeouts, Misc of Enhancements #9009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 1, 2023
Merged

[SFN] Support for global Timeouts, Misc of Enhancements #9009

merged 7 commits into from
Sep 1, 2023

Conversation

MEPalma
Copy link
Contributor

@MEPalma MEPalma commented Aug 29, 2023 •
edited
Loading

Motivation

Adds several enhancements and bug fixing to json path extractors, lambda task default inputs, and global timeouts, contributing to the greenification of #8779

Changes

  • Added global TimeoutSeconds fields for state machine definitions
  • Several behavioural fixes to the payloads carrying jsonpaths values
  • Fixed default lambda payload obfuscated by over normalisations in the task output logic
  • Fixes known issue with index out of range exception when evaluating json paths

@MEPalma MEPalma added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label Aug 29, 2023
@MEPalma MEPalma added this to the 2.3 milestone Aug 29, 2023
@MEPalma MEPalma self-assigned this Aug 29, 2023
@coveralls
Copy link

coveralls commented Aug 29, 2023 •
edited
Loading

Coverage Status

coverage: 80.766% (+0.007%) from 80.759% when pulling 26a1e4d on MEP-sfn-green-fixes into 6f5d756 on master.

@github-actions
Copy link

github-actions bot commented Aug 29, 2023 •
edited
Loading

LocalStack Community integration with Pro

       2 files         2 suites   1h 23m 57s ⏱️
2 152 tests 1 676 ✔️ 476 💤 0 ❌
2 153 runs  1 676 ✔️ 477 💤 0 ❌

Results for commit 50033da.

♻️ This comment has been updated with latest results.

@BrianMcBrayer
Copy link

Eagerly awaiting this to merge 🤞

dominikschubert
dominikschubert approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit, otherwise LGTM 👍

@MEPalma MEPalma merged commit 18a8a5a into master Sep 1, 2023
@MEPalma MEPalma deleted the MEP-sfn-green-fixes branch September 1, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikschubert dominikschubert dominikschubert approved these changes

Assignees

@MEPalma MEPalma

Labels
semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
2.3
Development

Successfully merging this pull request may close these issues.
4 participants
@MEPalma @coveralls @BrianMcBrayer @dominikschubert