Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bump moto-ext to 4.2.0.post1 #9044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 1, 2023
Merged

Bump moto-ext to 4.2.0.post1 #9044

merged 8 commits into from
Sep 1, 2023

Conversation

viren-nadkarni
Copy link
Member

@viren-nadkarni viren-nadkarni commented Sep 1, 2023 •
edited
Loading

Motivation

Bring in the latest Moto changes.

Changes

Stop using the clean_key_name that was removed in getmoto/moto#6602

@viren-nadkarni viren-nadkarni self-assigned this Sep 1, 2023
@viren-nadkarni viren-nadkarni added the semver: patch Non-breaking changes which can be included in patch releases label Sep 1, 2023
bentsku
bentsku reviewed Sep 1, 2023
View reviewed changes
localstack/services/s3/provider.py
@@ -1874,7 +1874,7 @@ def s3_response_is_delete_keys(fn, self):
"""
return get_safe(self.querystring, "$.x-id.0") == "DeleteObjects" or fn(self)

@patch(moto_s3_responses.S3ResponseInstance.parse_bucket_name_from_url, pass_target=False)
@patch(moto_s3_responses.S3Response.parse_bucket_name_from_url, pass_target=False)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should have been a sign from the big issue this bump is fixing, but well 🤷‍♂️ fixing the patch to properly work

localstack/services/secretsmanager/provider.py
@@ -314,23 +314,6 @@ def fake_secret_update(
self.last_changed_date = time.time()


class FakeSecretVersionStore(dict):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've ran some secretsmanager tests and it seems they run without the patch now, I think it has been fixed upstream with getmoto/moto#6720

@bentsku
Copy link
Contributor

bentsku commented Sep 1, 2023 •
edited
Loading

Seems like there's still an issue with Logs:

  File "/opt/code/localstack/localstack/services/logs/provider.py", line 318, in moto_put_log_events
    if events and self.destination_arn:
AttributeError: 'LogStream' object has no attribute 'destination_arn'

PR linked: getmoto/moto#6724
I'll take a look later tonight. I think a lot of these issues stems from this, because most of the failing test are tests that have a logs integration (Lambda, SNS, SQS...)

@github-actions
Copy link

github-actions bot commented Sep 1, 2023 •
edited
Loading

LocalStack Community integration with Pro

       2 files         2 suites   1h 27m 56s ⏱️
2 152 tests 1 676 ✔️ 476 💤 0 ❌
2 153 runs  1 676 ✔️ 477 💤 0 ❌

Results for commit bd4ac0f.

♻️ This comment has been updated with latest results.

@bentsku
Copy link
Contributor

bentsku commented Sep 1, 2023

Only test_last_updated_date failing because of difference in precision between timestamp in moto and our provider (moto round time.time() but secretsmanager should return 3 fraction digits). Adapted the test to check for relative equality instead of strict. The pipeline should now be green 🤞

@bentsku
Copy link
Contributor

bentsku commented Sep 1, 2023

Green -ext run on this branch: https://github.com/localstack/localstack-ext/actions/runs/6054306633

@bentsku bentsku marked this pull request as ready for review September 1, 2023 23:06
@thrau thrau merged commit 22d605b into master Sep 1, 2023
@thrau thrau deleted the bump-moto-ext branch September 1, 2023 23:29
@dfangl dfangl mentioned this pull request Sep 5, 2023
Merged
@bentsku bentsku mentioned this pull request Sep 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bentsku bentsku bentsku left review comments

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

@macnev2013 macnev2013 Awaiting requested review from macnev2013 macnev2013 is a code owner

@steffyP steffyP Awaiting requested review from steffyP

Assignees

@viren-nadkarni viren-nadkarni

Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@viren-nadkarni @bentsku @thrau @dfangl