Make AWS region name configurable for tests #9070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We could also consider dropping the |
dfangl
approved these changes
Sep 6, 2023
Removing the suffix `_NAME` aligns the environment variable naming with the AWS CLI using `AWS_REGION` (which overwrites `AWS_DEFAULT_REGION`). https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-envvars.html
Align environment variable naming with AWS CLI using Removing the suffix |
|
Flaky arm64 test unrelated and reported in flaky test list (already know flake) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We should have a configuration to change the test region. For cross-account tests, we should be able to configure the region in order to test cross-account tests within the same region.
Discovered during testing of the Lambda invocation loop rework #8970
/cc @dfangl @dominikschubert
Changes
Makes the AWS region name configurable in tests.