Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add test for s3 bucket concurrency #9072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 6, 2023
Merged

Add test for s3 bucket concurrency #9072

merged 4 commits into from
Sep 6, 2023

Conversation

dfangl
Copy link
Member

@dfangl dfangl commented Sep 5, 2023

Motivation

We had some problem with simultaneous bucket operations. This PR adds a test for it. It should be fixed with #9044

Changes

  • Add list wrapper to avoid issue with concurrent modification of a dict while iterating
  • Add test for 10 simultaneous bucket creations with the requirement of us-east-1 bucket creation idempotency.

@dfangl dfangl added the semver: patch Non-breaking changes which can be included in patch releases label Sep 5, 2023
Copy link
Contributor

@bentsku bentsku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice changes, and cool test! Barrier 😎

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

LocalStack Community integration with Pro

       2 files         2 suites   1h 31m 36s ⏱️
2 153 tests 1 677 ✔️ 476 💤 0
2 154 runs  1 677 ✔️ 477 💤 0

Results for commit 159a35f.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@bentsku bentsku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I've missed something. We're not cleaning up the buckets we've created 😬



class TestParallelBucketCreation:
@markers.aws.unknown
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@markers.aws.unknown
@markers.aws.only_localstack

@bentsku bentsku self-requested a review September 5, 2023 15:05
@dfangl dfangl merged commit f09439a into master Sep 6, 2023
@dfangl dfangl deleted the fix-moto-concurrency branch September 6, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants