fix secretsmanager PutSecretValue on empty secret #9077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominikschubert
approved these changes
Sep 6, 2023
Comment on lines
+499
to
+500
| # FIXME: remove for the next moto bump (above 4.2.post1) and uncomment line above | ||
| # remove all old AWSPREVIOUS stages |
There was a problem hiding this comment.
Completely unrelated and task for futures us:
Would be great if we can find a way to unify this kind of thing across the code base a bit. In a lot of cases this is just forgotten and then causes issues down the road when upstream changes.
There was a problem hiding this comment.
I could also imagine adding a unit test that will fail as soon as we update moto, so that we are automatically reminded to fix this 🤔
again: not really something that needs any action right now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
A regression was introduced in moto and part of localstack after #9044 when calling
PutSecretValueon a secret with no value.Changes
This adds a test for the fix in getmoto/moto#6775
Edit: well, apparently this has been fixed with getmoto/moto#6771
I don't know if we already want to do a moto bump, or we keep this fix inside LocalStack for now, this might be faster still.
I've also put the fix in the patch for the moment until the next moto bump where we can remove it and use the one from upstream. This fix is kinda urgent, as the customer is downgrading moto in their LocalStack container in the meantime and it introduces incompatibilities, especially with
logs.