Add removal warning for legacy lambda provider #9203
Conversation
Initial attempt for a utility to collect deprecations for specific values of environment variables.
This reverts commit a26c773.
| @@ -303,6 +303,22 @@ def log_deprecation_warnings(deprecations: Optional[List[EnvVarDeprecation]] = N | |||
| affected_deprecations = collect_affected_deprecations(deprecations) | |||
| log_env_warning(affected_deprecations) | |||
|
|
|||
| provider_override_lambda = os.environ.get("PROVIDER_OVERRIDE_LAMBDA") | |||
| if provider_override_lambda and provider_override_lambda in ["v1", "legacy"]: | |||
There was a problem hiding this comment.
Do we want/need this prominently at startup?
There was a problem hiding this comment.
Yes. The Lambda team discussed this makes sense for Lambda given the substantial difference. We want to highlight this and push users to adopt v2 or raise any blocking issues.
There was a problem hiding this comment.
Notice that the language differs from the lazily loaded message. This message is aligned to the regular LS-startup deprecation warnings.
The warning upon LS startup is much more present and appears right next to other important deprecation warnings. |
Motivation
v2provider became available as opt-in.v1provider was deprecated and we encouraged users to opt-in to our new Lambdav2provider.v2became the default implementation Switch to new Lambda provider implementation #6724.v1provider (this PR). We also ship the Lambda invocation loop rework Lambda invocation loop rework #8970 (re-write of data plane).Changes
Add a log warning when the legacy Lambda v1 provider is used. Only logged during initialization (
on_after_init) for people using the legacy Lambda service.Discussion
Pro-active warnings at LocalStack startup:
PROVIDER_OVERRIDE_LAMBDA=v1at the startup of LocalStack? We currently do not support this withEnvVarDeprecation. I drafted anEnvVarValueDeprecationina26c77375but reverted it because it needs further updates in the logging message and telemetry if we even need this.Consistency: Trying to align the language for the deprecations and removals of s3, lambda, stepfunctions /cc