Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove deprecated config USE_SINGLE_REGION #9374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 27, 2023
Merged

Remove deprecated config USE_SINGLE_REGION #9374

merged 2 commits into from
Oct 27, 2023

Conversation

viren-nadkarni
Copy link
Member

@viren-nadkarni viren-nadkarni commented Oct 18, 2023 •
edited
Loading

Motivation

The USE_SINGLE_REGION environment config variable was used in early years of LocalStack when multi-region was unsupported. It has since been deprecated.

This PR removes this config variable for the upcoming major release.

@viren-nadkarni viren-nadkarni added the semver: major Breaking changes which can be included in a major release only label Oct 18, 2023
@viren-nadkarni viren-nadkarni self-assigned this Oct 18, 2023
@localstack-bot
Copy link
Contributor

Currently, only minor and patch changes are allowed on master. Your PR labels (semver: major) indicate that it cannot be merged into the master at this time.

@coveralls
Copy link

coveralls commented Oct 18, 2023 •
edited
Loading

Coverage Status

coverage: 83.694% (+0.02%) from 83.677% when pulling c2c3a93 on remove-use-single-region into 85abf31 on release/v3.0.

@github-actions
Copy link

github-actions bot commented Oct 18, 2023 •
edited
Loading

LocalStack Community integration with Pro

       2 files  ±0         2 suites  ±0   1h 22m 47s ⏱️ + 12m 36s
2 287 tests ±0  1 708 ✔️ ±0  579 💤 ±0  0 ❌ ±0 
2 288 runs  ±0  1 708 ✔️ ±0  580 💤 ±0  0 ❌ ±0 

Results for commit c2c3a93. ± Comparison against base commit 85abf31.

♻️ This comment has been updated with latest results.

@viren-nadkarni viren-nadkarni changed the base branch from master to release/v3.0 October 24, 2023 09:34
@viren-nadkarni viren-nadkarni marked this pull request as ready for review October 24, 2023 09:41
@viren-nadkarni viren-nadkarni requested a review from thrau as a code owner October 24, 2023 09:41
@viren-nadkarni viren-nadkarni requested review from alexrashed and removed request for thrau October 24, 2023 09:41
alexrashed
alexrashed reviewed Oct 24, 2023
View reviewed changes
Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see that we are finally getting rid of the old deprecated variables. 🧹
However, I think we should still show warnings to users who are still using it...

@viren-nadkarni viren-nadkarni force-pushed the remove-use-single-region branch from 46efde0 to f12bd3b Compare October 27, 2023 07:13
@alexrashed alexrashed force-pushed the remove-use-single-region branch from f12bd3b to c2c3a93 Compare October 27, 2023 07:13
alexrashed
alexrashed approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@alexrashed alexrashed left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aweseome! Thanks for addressing the comments and bringing the removal of the USE_SINGLE_REGION over the line! 🚀

@viren-nadkarni viren-nadkarni merged commit 25062c0 into release/v3.0 Oct 27, 2023
@viren-nadkarni viren-nadkarni deleted the remove-use-single-region branch October 27, 2023 08:12
@alexrashed alexrashed mentioned this pull request Oct 27, 2023
Merged
20 tasks
alexrashed pushed a commit that referenced this pull request Oct 28, 2023
@viren-nadkarni @alexrashed
Remove deprecated config USE_SINGLE_REGION (#9374)
306317a
localstack-bot pushed a commit that referenced this pull request Oct 31, 2023
@viren-nadkarni @alexrashed
Remove deprecated config USE_SINGLE_REGION (#9374)
a85bc6b
alexrashed pushed a commit that referenced this pull request Oct 31, 2023
@viren-nadkarni @alexrashed
Remove deprecated config USE_SINGLE_REGION (#9374)
6652964
alexrashed pushed a commit that referenced this pull request Nov 1, 2023
@viren-nadkarni @alexrashed
Remove deprecated config USE_SINGLE_REGION (#9374)
ad97fd8
alexrashed pushed a commit that referenced this pull request Nov 1, 2023
@viren-nadkarni @alexrashed
Remove deprecated config USE_SINGLE_REGION (#9374)
c5c1082
alexrashed pushed a commit that referenced this pull request Nov 1, 2023
@viren-nadkarni @alexrashed
Remove deprecated config USE_SINGLE_REGION (#9374)
f59273e
alexrashed pushed a commit that referenced this pull request Nov 1, 2023
@viren-nadkarni @alexrashed
Remove deprecated config USE_SINGLE_REGION (#9374)
844362f
alexrashed pushed a commit that referenced this pull request Nov 2, 2023
@viren-nadkarni @alexrashed
Remove deprecated config USE_SINGLE_REGION (#9374)
c7fcb77
alexrashed pushed a commit that referenced this pull request Nov 2, 2023
@viren-nadkarni @alexrashed
Remove deprecated config USE_SINGLE_REGION (#9374)
b462172
alexrashed pushed a commit that referenced this pull request Nov 2, 2023
@viren-nadkarni @alexrashed
Remove deprecated config USE_SINGLE_REGION (#9374)
50f1533
alexrashed pushed a commit that referenced this pull request Nov 2, 2023
@viren-nadkarni @alexrashed
Remove deprecated config USE_SINGLE_REGION (#9374)
8fd9480
localstack-bot pushed a commit that referenced this pull request Nov 3, 2023
@viren-nadkarni
Remove deprecated config USE_SINGLE_REGION (#9374)
462fdcd
alexrashed pushed a commit that referenced this pull request Nov 3, 2023
@viren-nadkarni @alexrashed
Remove deprecated config USE_SINGLE_REGION (#9374)
61a5f06
alexrashed pushed a commit that referenced this pull request Nov 4, 2023
@viren-nadkarni @alexrashed
Remove deprecated config USE_SINGLE_REGION (#9374)
1f16bad
@viren-nadkarni viren-nadkarni mentioned this pull request Nov 7, 2023
Merged
localstack-bot pushed a commit that referenced this pull request Nov 7, 2023
@viren-nadkarni
Remove deprecated config USE_SINGLE_REGION (#9374)
ffb6bb4
alexrashed pushed a commit that referenced this pull request Nov 7, 2023
@viren-nadkarni @alexrashed
Remove deprecated config USE_SINGLE_REGION (#9374)
9b1295c
alexrashed pushed a commit that referenced this pull request Nov 7, 2023
@viren-nadkarni @alexrashed
Remove deprecated config USE_SINGLE_REGION (#9374)
4f3a31b
localstack-bot pushed a commit that referenced this pull request Nov 9, 2023
@viren-nadkarni
Remove deprecated config USE_SINGLE_REGION (#9374)
b1ad142
alexrashed pushed a commit that referenced this pull request Nov 9, 2023
@viren-nadkarni @alexrashed
Remove deprecated config USE_SINGLE_REGION (#9374)
359a26c
alexrashed pushed a commit that referenced this pull request Nov 9, 2023
@viren-nadkarni @alexrashed
Remove deprecated config USE_SINGLE_REGION (#9374)
993a51a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexrashed alexrashed alexrashed approved these changes

Assignees

@viren-nadkarni viren-nadkarni

Labels
semver: major Breaking changes which can be included in a major release only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@viren-nadkarni @localstack-bot @coveralls @alexrashed