LocalStack Community integration with Pro

       2 files  ±0         2 suites  ±0   1h 13m 52s ⏱️ -49s
2 268 tests ±0  1 691 ✔️ ±0  577 💤 ±0  0 ❌ ±0 
2 269 runs  ±0  1 691 ✔️ ±0  578 💤 ±0  0 ❌ ±0 

Results for commit 45b2c26. ± Comparison against base commit c24bf15.

♻️ This comment has been updated with latest results.

@alexrashed I think you're right, I was thinking about this as well.
How would you feel about removing all the conditional around LEGACY_S3_PROVIDER in tests in master first? That would reduce the numbers of files by a good amount, and we don't run the tests suite with it anymore so the tests would just break when ran against it, which is no big deal.

I think the tests themselves are not really the problem, but the actual service implementations and utils code which uses the LEGACY_S3_PROVIDER variable. A potential way around this would be to just set it to False (instead of reading the env var) and basically leaving everything else. This would essentially deactivate the whole feature, with a single line of code.
Then we could remove it silently in the background in upcoming changes (after the release branch has been merged into master). However, I think it's nice to have this together in a single PR, and collect the dopamine of the removals.
So let's move forward with the changes as they are in here 🚀 🧹

I see. Yes, deleting the entry in the providers.py and setting it to False would have made the same, but the cleaning would feel different! If it becomes too difficult to rebase until the release, we can always revert and keep it for after the release like you explained. I'll remove the leftovers comments and merge then.