Thanks to visit codestin.com
Credit goes to github.com

Skip to content

SQS: Use the 'standard' queue URL strategy by default #9468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2023
Merged

SQS: Use the 'standard' queue URL strategy by default #9468

merged 1 commit into from
Nov 7, 2023

Conversation

viren-nadkarni
Copy link
Member

Motivation

This PR makes the standard SQS queue URL strategy the default.

This will enable out-of-the-box multi-account and multi-region support in LocalStack SQS.

Related

Depends on #9454

@viren-nadkarni viren-nadkarni added the semver: major Breaking changes which can be included in a major release only label Oct 25, 2023
@viren-nadkarni viren-nadkarni self-assigned this Oct 25, 2023
@viren-nadkarni viren-nadkarni mentioned this pull request Oct 25, 2023
Merged
@github-actions
Copy link

github-actions bot commented Oct 25, 2023 •
edited
Loading

LocalStack Community integration with Pro

       2 files  ±0         2 suites  ±0   1h 2m 28s ⏱️ - 4m 30s
2 325 tests ±0  1 790 ✔️ ±0  535 💤 ±0  0 ❌ ±0 
2 326 runs  ±0  1 790 ✔️ ±0  536 💤 ±0  0 ❌ ±0 

Results for commit 32cee9b. ± Comparison against base commit 1777130.

♻️ This comment has been updated with latest results.

@coveralls
Copy link

coveralls commented Oct 25, 2023 •
edited
Loading

Coverage Status

coverage: 83.671% (-0.006%) from 83.677% when pulling 9370b05 on sqs-default-endpoint-strategy into 85abf31 on release/v3.0.

@localstack-bot localstack-bot force-pushed the release/v3.0 branch 2 times, most recently from c97ddc3 to 85abf31 Compare October 27, 2023 05:03
@viren-nadkarni viren-nadkarni force-pushed the sqs-default-endpoint-strategy branch from 5aca892 to 9370b05 Compare October 27, 2023 07:12
@alexrashed alexrashed force-pushed the release/v3.0 branch 10 times, most recently from 19c8422 to 6ff5c4c Compare November 2, 2023 09:24
@alexrashed alexrashed force-pushed the release/v3.0 branch 2 times, most recently from fb5da7d to 99278b3 Compare November 4, 2023 13:46
@viren-nadkarni viren-nadkarni force-pushed the sqs-default-endpoint-strategy branch from 9370b05 to 32cee9b Compare November 6, 2023 13:20
@viren-nadkarni viren-nadkarni marked this pull request as ready for review November 6, 2023 13:21
@viren-nadkarni viren-nadkarni requested a review from thrau as a code owner November 6, 2023 13:21
alexrashed
alexrashed approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Nice and clean feature flag switch! 🧹

@viren-nadkarni viren-nadkarni merged commit 069c499 into release/v3.0 Nov 7, 2023
@viren-nadkarni viren-nadkarni deleted the sqs-default-endpoint-strategy branch November 7, 2023 03:38
localstack-bot pushed a commit that referenced this pull request Nov 7, 2023
@viren-nadkarni
SQS: Use the 'standard' queue URL strategy by default (#9468)
42fe64e
alexrashed pushed a commit that referenced this pull request Nov 7, 2023
@viren-nadkarni @alexrashed
SQS: Use the 'standard' queue URL strategy by default (#9468)
dffe61f
alexrashed pushed a commit that referenced this pull request Nov 7, 2023
@viren-nadkarni @alexrashed
SQS: Use the 'standard' queue URL strategy by default (#9468)
f183c6f
@viren-nadkarni viren-nadkarni mentioned this pull request Nov 8, 2023
Merged
localstack-bot pushed a commit that referenced this pull request Nov 9, 2023
@viren-nadkarni
SQS: Use the 'standard' queue URL strategy by default (#9468)
2b63064
alexrashed pushed a commit that referenced this pull request Nov 9, 2023
@viren-nadkarni @alexrashed
SQS: Use the 'standard' queue URL strategy by default (#9468)
562503c
alexrashed pushed a commit that referenced this pull request Nov 9, 2023
@viren-nadkarni @alexrashed
SQS: Use the 'standard' queue URL strategy by default (#9468)
07319b7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexrashed alexrashed alexrashed approved these changes

@thrau thrau Awaiting requested review from thrau

Assignees

@viren-nadkarni viren-nadkarni

Labels
semver: major Breaking changes which can be included in a major release only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@viren-nadkarni @coveralls @alexrashed