Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Move lambda v1 to legacy package #9473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Oct 27, 2023
Merged

Move lambda v1 to legacy package #9473

merged 13 commits into from
Oct 27, 2023

Conversation

joe4dev
Copy link
Member

@joe4dev joe4dev commented Oct 25, 2023 •
edited
Loading

Motivation

This PR prepares for removing the old Lambda provider. We want to minimize the major changes upon 3.0 and therefore move lambda code to a legacy package.

Changes

  • Move Lambda V1 implementation to legacy package (similar how it already exists in localstack-ext)
  • Refactor tests and deprecated usages of lambda_util.py (mainly related to Runtime variables)
  • Split up lambda_utils.py:
    • Move old code into legacy
    • Move event source listener helpers into a separate file event_source_listerners/utils.py
    • Move Docker/container networking helpers into separate file networking.py

TODO

This first iteration is ready. Some refinements can be tackled in more limited scoped follow-ups.

See internal Notion task

@joe4dev joe4dev added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label Oct 25, 2023
@joe4dev joe4dev self-assigned this Oct 25, 2023
@github-actions
Copy link

github-actions bot commented Oct 25, 2023 •
edited
Loading

LocalStack Community integration with Pro

       2 files         2 suites   1h 7m 27s ⏱️
2 288 tests 1 719 ✔️ 569 💤 0 ❌
2 289 runs  1 719 ✔️ 570 💤 0 ❌

Results for commit 82205c3.

♻️ This comment has been updated with latest results.

@coveralls
Copy link

coveralls commented Oct 25, 2023 •
edited
Loading

Coverage Status

coverage: 82.428% (+0.004%) from 82.424% when pulling 82205c3 on move-lambda-v1-to-legacy-package into 338df4b on master.

@joe4dev joe4dev marked this pull request as ready for review October 26, 2023 10:27
@joe4dev joe4dev force-pushed the move-lambda-v1-to-legacy-package branch from 83e2787 to 740b522 Compare October 27, 2023 08:44
@joe4dev joe4dev requested review from alexrashed and removed request for MEPalma October 27, 2023 09:55
alexrashed
alexrashed approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Great to see the restructuring getting over the line, paving the way for removing all the legacy code! 🚀 🧹

@joe4dev joe4dev force-pushed the move-lambda-v1-to-legacy-package branch from 740b522 to 82205c3 Compare October 27, 2023 20:35
@joe4dev joe4dev merged commit 2991501 into master Oct 27, 2023
@joe4dev joe4dev deleted the move-lambda-v1-to-legacy-package branch October 27, 2023 21:45
pinzon pushed a commit that referenced this pull request Oct 30, 2023
@joe4dev @pinzon
Move lambda v1 to legacy package (#9473)
f2f2fd6
@joe4dev joe4dev mentioned this pull request Nov 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexrashed alexrashed alexrashed approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

@bentsku bentsku Awaiting requested review from bentsku bentsku is a code owner

@macnev2013 macnev2013 Awaiting requested review from macnev2013

@dfangl dfangl Awaiting requested review from dfangl dfangl is a code owner

@calvernaz calvernaz Awaiting requested review from calvernaz

Assignees

@joe4dev joe4dev

Labels
semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joe4dev @coveralls @alexrashed