Remove fallback account ID and region for core ARN builder #9528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b69aa7f to
499a6da
Compare
bentsku
reviewed
Nov 13, 2023
| @@ -593,7 +593,7 @@ def capitalize_header_name_from_snake_case(header_name: str) -> str: | |||
| return "-".join([part.capitalize() for part in header_name.split("-")]) | |||
|
|
|||
|
|
|||
| def get_kms_key_arn(kms_key: str, account_id: str, bucket_region: str = None) -> Optional[str]: | |||
| def get_kms_key_arn(kms_key: str, account_id: str, bucket_region: str) -> Optional[str]: | |||
There was a problem hiding this comment.
great catch, thanks for fixing this! 🙏
alexrashed
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Over the past few weeks, ARN builders in LocalStack were refactored to use request context account IDs and regions: #9398
This PR wraps up these refactorings.
All the ARN builders use a common function
_resource_arn()which falls back to the problematicget_aws_account_id()andaws_stack.get_region()utilities. This PR removes these fallbacks.Tests
Ext Integration Tests # 3441 🟢