Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Deprecate community pods #9530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2023
Merged

Deprecate community pods #9530

merged 1 commit into from
Nov 4, 2023

Conversation

giograno
Copy link
Member

@giograno giograno commented Nov 1, 2023

Motivation

We are discontinuing community pods (see here).
I will follow up by moving the code in the persistence plugin into ext.

Changes

Remove the installation of the localstack persistence plugin in the community image.

@giograno giograno added the semver: major Breaking changes which can be included in a major release only label Nov 1, 2023
@giograno giograno self-assigned this Nov 1, 2023
@alexrashed alexrashed force-pushed the release/v3.0 branch 6 times, most recently from 19c8422 to 6ff5c4c Compare November 2, 2023 09:24
@giograno giograno force-pushed the deprecate-community-pods branch from 4dd5344 to b25936b Compare November 2, 2023 13:19
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2023 •
edited
Loading

LocalStack Community integration with Pro

       2 files  ±0         2 suites  ±0   1h 12m 41s ⏱️ - 1m 25s
2 325 tests ±0  1 748 ✔️ ±0  577 💤 ±0  0 ❌ ±0 
2 326 runs  ±0  1 748 ✔️ ±0  578 💤 ±0  0 ❌ ±0 

Results for commit 2599209. ± Comparison against base commit e77b647.

♻️ This comment has been updated with latest results.

@coveralls
Copy link

Coverage Status

coverage: 83.737% (-0.005%) from 83.742% when pulling b25936b on deprecate-community-pods into c0b020b on release/v3.0.

@giograno giograno force-pushed the deprecate-community-pods branch from b25936b to a395f95 Compare November 3, 2023 13:09
@giograno giograno marked this pull request as ready for review November 3, 2023 13:09
@giograno giograno requested a review from alexrashed as a code owner November 3, 2023 13:09
alexrashed
alexrashed approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🧹

@giograno giograno force-pushed the deprecate-community-pods branch from a395f95 to 2599209 Compare November 3, 2023 13:36
@alexrashed alexrashed merged commit fb5da7d into release/v3.0 Nov 4, 2023
@alexrashed alexrashed deleted the deprecate-community-pods branch November 4, 2023 13:38
@alexrashed alexrashed mentioned this pull request Nov 4, 2023
Merged
20 tasks
alexrashed pushed a commit that referenced this pull request Nov 4, 2023
@giograno @alexrashed
remove persistence plugin to discountinue community pods (#9530)
99278b3
localstack-bot pushed a commit that referenced this pull request Nov 7, 2023
@giograno
remove persistence plugin to discountinue community pods (#9530)
63ad759
alexrashed pushed a commit that referenced this pull request Nov 7, 2023
@giograno @alexrashed
remove persistence plugin to discountinue community pods (#9530)
999ac03
alexrashed pushed a commit that referenced this pull request Nov 7, 2023
@giograno @alexrashed
remove persistence plugin to discountinue community pods (#9530)
63e3c28
localstack-bot pushed a commit that referenced this pull request Nov 9, 2023
@giograno
remove persistence plugin to discountinue community pods (#9530)
26587d0
alexrashed pushed a commit that referenced this pull request Nov 9, 2023
@giograno @alexrashed
remove persistence plugin to discountinue community pods (#9530)
8480b19
alexrashed pushed a commit that referenced this pull request Nov 9, 2023
@giograno @alexrashed
remove persistence plugin to discountinue community pods (#9530)
1dd7030
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexrashed alexrashed alexrashed approved these changes

@HarshCasper HarshCasper HarshCasper approved these changes

@thrau thrau Awaiting requested review from thrau

@baermat baermat Awaiting requested review from baermat

@viren-nadkarni viren-nadkarni Awaiting requested review from viren-nadkarni

@bentsku bentsku Awaiting requested review from bentsku

@macnev2013 macnev2013 Awaiting requested review from macnev2013

@steffyP steffyP Awaiting requested review from steffyP

@silv-io silv-io Awaiting requested review from silv-io

@sannya-singal sannya-singal Awaiting requested review from sannya-singal

@dominikschubert dominikschubert Awaiting requested review from dominikschubert

@dfangl dfangl Awaiting requested review from dfangl

@calvernaz calvernaz Awaiting requested review from calvernaz

Assignees

@giograno giograno

Labels
semver: major Breaking changes which can be included in a major release only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@giograno @coveralls @alexrashed @HarshCasper