Thanks to visit codestin.com
Credit goes to github.com

Skip to content

remove deprecated HTTP endpoints / routes #9533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 2, 2023
Merged

remove deprecated HTTP endpoints / routes #9533

merged 2 commits into from
Nov 2, 2023

Conversation

alexrashed
Copy link
Member

@alexrashed alexrashed commented Nov 2, 2023 •
edited
Loading

Motivation

This PR removes the routing for endpoints which have been deprecated for a long time:

  • /health → Now /_localstack/health (since 1.3.0 )
  • /cloudwatch/metrics/raw → Now /_aws/cloudwatch/metrics/raw (since 1.3.0)
  • /_localstack/ses → Now /_aws/ses (since 1.4.0)

Changes

  • Removes the registration of the deprecated routes for the health endpoint and the raw metrics from CloudWatch. /cc @steffyP

Associated PRs

Prior to the removal, all known usages in the repos of the localstack org on GitHub have been migrated:

@alexrashed alexrashed added the semver: major Breaking changes which can be included in a major release only label Nov 2, 2023
@alexrashed alexrashed added this to the 3.0 milestone Nov 2, 2023
@alexrashed alexrashed self-assigned this Nov 2, 2023
@alexrashed alexrashed force-pushed the remove-deprecated-endpoints-core branch from 0761562 to 00bdbbb Compare November 2, 2023 10:11
viren-nadkarni
viren-nadkarni approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@viren-nadkarni viren-nadkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔️

@alexrashed alexrashed force-pushed the remove-deprecated-endpoints-core branch from 92f04ed to f0efc8e Compare November 2, 2023 11:30
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2023

LocalStack Community integration with Pro

       2 files  ±0         2 suites  ±0   1h 14m 55s ⏱️ + 4m 36s
2 324 tests  - 1  1 747 ✔️  - 1  577 💤 ±0  0 ❌ ±0 
2 325 runs   - 1  1 747 ✔️  - 1  578 💤 ±0  0 ❌ ±0 

Results for commit f0efc8e. ± Comparison against base commit c5ffecd.

steffyP
steffyP approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@steffyP steffyP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing the deprecated endpoints 🙏
LGTM!

@coveralls
Copy link

Coverage Status

coverage: 83.685% (-0.09%) from 83.779% when pulling f0efc8e on remove-deprecated-endpoints-core into c5ffecd on release/v3.0.

@alexrashed alexrashed merged commit c0b020b into release/v3.0 Nov 2, 2023
@alexrashed alexrashed deleted the remove-deprecated-endpoints-core branch November 2, 2023 12:51
@alexrashed alexrashed mentioned this pull request Nov 2, 2023
Merged
20 tasks
localstack-bot pushed a commit that referenced this pull request Nov 3, 2023
@alexrashed
remove deprecated HTTP endpoints / routes (#9533)
280ea01
alexrashed added a commit that referenced this pull request Nov 3, 2023
@alexrashed
remove deprecated HTTP endpoints / routes (#9533)
e6f2970
alexrashed added a commit that referenced this pull request Nov 4, 2023
@alexrashed
remove deprecated HTTP endpoints / routes (#9533)
0163285
localstack-bot pushed a commit that referenced this pull request Nov 7, 2023
@alexrashed
remove deprecated HTTP endpoints / routes (#9533)
a6cea53
alexrashed added a commit that referenced this pull request Nov 7, 2023
@alexrashed
remove deprecated HTTP endpoints / routes (#9533)
54dd1d3
alexrashed added a commit that referenced this pull request Nov 7, 2023
@alexrashed
remove deprecated HTTP endpoints / routes (#9533)
1da1e09
localstack-bot pushed a commit that referenced this pull request Nov 9, 2023
@alexrashed
remove deprecated HTTP endpoints / routes (#9533)
c012afb
alexrashed added a commit that referenced this pull request Nov 9, 2023
@alexrashed
remove deprecated HTTP endpoints / routes (#9533)
2e5327c
alexrashed added a commit that referenced this pull request Nov 9, 2023
@alexrashed
remove deprecated HTTP endpoints / routes (#9533)
2b7e59f
@guille-sage guille-sage mentioned this pull request Jan 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viren-nadkarni viren-nadkarni viren-nadkarni approved these changes

@steffyP steffyP steffyP approved these changes

@silv-io silv-io Awaiting requested review from silv-io

@thrau thrau Awaiting requested review from thrau

@baermat baermat Awaiting requested review from baermat

@bentsku bentsku Awaiting requested review from bentsku

@macnev2013 macnev2013 Awaiting requested review from macnev2013

@sannya-singal sannya-singal Awaiting requested review from sannya-singal

@dominikschubert dominikschubert Awaiting requested review from dominikschubert

@dfangl dfangl Awaiting requested review from dfangl

@calvernaz calvernaz Awaiting requested review from calvernaz

Assignees

@alexrashed alexrashed

Labels
semver: major Breaking changes which can be included in a major release only
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@alexrashed @coveralls @viren-nadkarni @steffyP