Thanks to visit codestin.com
Credit goes to github.com

Skip to content

KMS: Remove legacy 'local-kms' based provider #9536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

viren-nadkarni
Copy link
Member

Motivation

The old 'local-kms' based KMS provider was deprecated in v1.4. It will be removed in v3.

Use of the legacy option KMS_PROVIDER will now print a warning.

@viren-nadkarni viren-nadkarni added the semver: major Breaking changes which can be included in a major release only label Nov 2, 2023
@viren-nadkarni viren-nadkarni self-assigned this Nov 2, 2023
@coveralls
Copy link

Coverage Status

Changes unknown when pulling 57680d5 on remove-kms-local-provider into ** on release/v3.0**.

Copy link

github-actions bot commented Nov 2, 2023

LocalStack Community integration with Pro

       2 files  ±0         2 suites  ±0   1h 6m 59s ⏱️ - 3m 13s
2 324 tests ±0  1 747 ✔️ ±0  577 💤 ±0  0 ±0 
2 325 runs  ±0  1 747 ✔️ ±0  578 💤 ±0  0 ±0 

Results for commit 57680d5. ± Comparison against base commit 6ff5c4c.

@viren-nadkarni viren-nadkarni marked this pull request as ready for review November 2, 2023 12:10
@viren-nadkarni viren-nadkarni requested review from alexrashed and removed request for thrau, silv-io and HarshCasper November 2, 2023 12:11
Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean removal! 🧹 🔝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: major Breaking changes which can be included in a major release only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants