Thanks to visit codestin.com
Credit goes to github.com

Skip to content

remove old deprecations #9572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 7, 2023
Merged

remove old deprecations #9572

merged 7 commits into from
Nov 7, 2023

Conversation

alexrashed
Copy link
Member

Motivation

This PR aims at collectively removing a lot of configuration variables which have been deprecated for a long time.

Changes

  • This PR removes or cleans up:
    • KINESIS_INITIALIZE_STREAMS
    • MOCK_UNIMPLEMENTED
    • INIT_SCRIPTS_PATH
    • LEGACY_INIT_DIR
    • HOST_TMP_FOLDER
    • LEGACY_DIRECTORIES
    • LEGACY_EDGE_PROXY (a proper cleanup of the legacy edge proxy code will follow in another PR)
    • EDGE_FORWARD_URL
    • SYNCHRONOUS_*_EVENTS
    • KINESIS_PROVIDER
    • LAMBDA_EXECUTOR
    • LAMBDA_STAY_OPEN_MODE
    • LAMBDA_REMOTE_DOCKER
    • LAMBDA_CODE_EXTRACT_TIME
    • LAMBDA_CONTAINER_REGISTRY
    • LAMBDA_FALLBACK_URL
    • LAMBDA_FORWARD_URL
    • LAMBDA_XRAY_INIT
    • ES_CUSTOM_BACKEND
    • ES_MULTI_CLUSTER
    • ES_ENDPOINT_STRATEGY
  • Most of these environment variables were already non-functional and long deprecated, where I only ensured that their usage is logged properly.

@alexrashed alexrashed added the semver: major Breaking changes which can be included in a major release only label Nov 7, 2023
@alexrashed alexrashed added this to the 3.0 milestone Nov 7, 2023
@alexrashed alexrashed requested a review from dfangl November 7, 2023 12:32
@alexrashed alexrashed self-assigned this Nov 7, 2023
@alexrashed alexrashed mentioned this pull request Nov 7, 2023
Merged
20 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2023

LocalStack Community integration with Pro

       2 files  ±0         2 suites  ±0   1h 6m 25s ⏱️ + 6m 58s
2 302 tests ±0  1 785 ✔️ ±0  517 💤 ±0  0 ❌ ±0 
2 303 runs  ±0  1 785 ✔️ ±0  518 💤 ±0  0 ❌ ±0 

Results for commit e0ba7a5. ± Comparison against base commit dffe61f.

@coveralls
Copy link

Coverage Status

coverage: 84.251% (+0.03%) from 84.224%
when pulling e0ba7a5 on remove-old-deprecations
into dffe61f on release/v3.0.

dfangl
dfangl approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@dfangl dfangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟩 🟥🟥🟥🟥🟥 🎉

@alexrashed alexrashed merged commit e0ba7a5 into release/v3.0 Nov 7, 2023
@alexrashed alexrashed deleted the remove-old-deprecations branch November 7, 2023 14:37
alexrashed added a commit that referenced this pull request Nov 9, 2023
@alexrashed
remove ES_ENDPOINT_STRATEGY, ES_MULTI_CLUSTER, ES_CUSTOM_BACKEND (#9572)
ded8498
alexrashed added a commit that referenced this pull request Nov 9, 2023
@alexrashed
ensure all legacy (removed) lambda envs are forwarded and logged (#9572)
366dcd6
alexrashed added a commit that referenced this pull request Nov 9, 2023
@alexrashed
ensure all removed SYNCHRONOUS_*_EVENTS are logged (#9572)
a592889
alexrashed added a commit that referenced this pull request Nov 9, 2023
@alexrashed
ensure removed KINESIS_PROVIDER is logged (#9572)
5629e6d
alexrashed added a commit that referenced this pull request Nov 9, 2023
@alexrashed
remove LEGACY_EDGE_PROXY and EDGE_FORWARD_URL, log usage (#9572)
a59f1a2
alexrashed added a commit that referenced this pull request Nov 9, 2023
@alexrashed
remove legacy (init) dirs, HOST_TMP_FOLDER, MOCK_UNIMPLEMENTED (#9572)
02dfbde
alexrashed added a commit that referenced this pull request Nov 9, 2023
@alexrashed
remove KINESIS_INITIALIZE_STREAMS (#9572)
d9de2c7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfangl dfangl dfangl approved these changes

@thrau thrau Awaiting requested review from thrau

@HarshCasper HarshCasper Awaiting requested review from HarshCasper

Assignees

@alexrashed alexrashed

Labels
semver: major Breaking changes which can be included in a major release only
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@alexrashed @coveralls @dfangl