Update remaining usages of LOCALHOST_HOSTNAME #9578
Conversation
| @@ -603,16 +603,6 @@ def populate_edge_configuration( | |||
| localstack_host_raw = environment.get("LOCALSTACK_HOST") | |||
| gateway_listen_raw = environment.get("GATEWAY_LISTEN") | |||
|
|
|||
| # new for v2 | |||
There was a problem hiding this comment.
Nice to see this complexity go and keep LOCALSTACK_HOST purely cosmetic ✨
also localstack_host_port was confusing to follow
We have not advertised this shortcut anywhere. So let's hope this breaking change goes smooth 🤞
There was a problem hiding this comment.
It would be interesting to know why we added it in the first place but I guess that remains unknown 🪄
| # * ip only | ||
| # * host and ip | ||
| # and there are two variables so 16 total tests | ||
| @pytest.mark.parametrize( |
There was a problem hiding this comment.
lovely thorough test coverage 💯
We do lose the human-readable names but that's worth the full coverage (at least for len(gateway_listen) == 1) ⚖️
There was a problem hiding this comment.
It would also simplify removing EDGE_PORT from populate_edge_configuration if we wish to do so later 👍
I've put in the PR description, so it's fine right?! 🤷 |
Motivation
Some usages of
LOCALHOST_HOSTNAMEwere missed during the migration toLOCALSTACK_HOST. This PR addresses that.Note: usages of returning
LOCALHOST_HOSTNAMEare changed, not internal usages ofLOCALHOST_HOSTNAMEto return tolocalhost. This is important, becauseLOCALSTACK_HOSTis a "cosmetic" variable, and as such should not be used as a value to reachlocalhost.Changes
LOCALHOST_HOSTNAMEto useLOCALSTACK_HOST.LOCALSTACK_HOSTno longer configures the edge port ifGATEWAY_LISTENis not specified