Thanks to visit codestin.com
Credit goes to github.com

Skip to content

remove legacy edge proxy and generic proxy #9581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 9, 2023
Merged

remove legacy edge proxy and generic proxy #9581

merged 5 commits into from
Nov 9, 2023

Conversation

alexrashed
Copy link
Member

Motivation

#9467 contains the removal of the last legacy providers.
This now allows us to remove the old (and now dead) code around the GenericProxy, its ProxyListeners, and the legacy edge serving.
This PR supersedes #9467.

Changes

  • Remove all the dead code related to the GenericProxy, its ProxyListeners, and the legacy edge serving.
  • Removes the direct dependency on flask and flask-cors, since those are not used anymore.
    • However, there are some references to FlaskResponse in the API Gateway code. This should be removed asap to finally get rid of the last references.
    • This should be done by getting rid of request_context.THREAD_LOCAL and accounts.REQUEST_CTX_TLS. /cc @bentsku @calvernaz @viren-nadkarni

Testing

  • This PR definitely removes the biggest parts of the legacy code, but there might still be some stuff left. We should take a closer look at the coverage analysis of this PR to identify other, now dead, parts.
  • Besides that, our tests cover pretty much every aspect. If they are green, we should be good to go! 🚀

@alexrashed alexrashed added the semver: major Breaking changes which can be included in a major release only label Nov 8, 2023
@alexrashed alexrashed added this to the 3.0 milestone Nov 8, 2023
@alexrashed alexrashed self-assigned this Nov 8, 2023
@alexrashed alexrashed requested review from whummer and dfangl November 8, 2023 11:46
@alexrashed alexrashed marked this pull request as draft November 8, 2023 12:41
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2023 •
edited
Loading

LocalStack Community integration with Pro

       2 files  ±0         2 suites  ±0   1h 19m 42s ⏱️ + 6m 2s
2 307 tests ±0  2 011 ✔️ ±0  296 💤 ±0  0 ❌ ±0 
2 308 runs  ±0  2 011 ✔️ ±0  297 💤 ±0  0 ❌ ±0 

Results for commit 73e6008. ± Comparison against base commit 45b80ca.

♻️ This comment has been updated with latest results.

bentsku
bentsku reviewed Nov 8, 2023
View reviewed changes
@coveralls
Copy link

coveralls commented Nov 8, 2023 •
edited
Loading

Coverage Status

coverage: 83.901% (+0.1%) from 83.779%
when pulling 73e6008 on remove-legacy-edge-proxy-new
into 45b80ca on release/v3.0.

@alexrashed alexrashed mentioned this pull request Nov 8, 2023
Merged
20 tasks
@alexrashed alexrashed marked this pull request as ready for review November 8, 2023 16:19
bentsku
bentsku approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@bentsku bentsku left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incredible, thank you so much for tackling this! I couldn't find the FlaskReponse in the APIGW code, could you point me to it?

The changes look great, LGTM! 🚀 🧹 I'll let others validate as well, but this is such a great achievement!

@alexrashed alexrashed force-pushed the remove-legacy-edge-proxy-new branch from 124399e to 9dd180b Compare November 9, 2023 06:28
dominikschubert
dominikschubert approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 😍
It did really do a great job until now, but still glad we can finally get rid of it 😉

Remaining test failure should be fixed with #9586

@alexrashed alexrashed requested a review from giograno as a code owner November 9, 2023 07:33
@alexrashed alexrashed force-pushed the remove-legacy-edge-proxy-new branch from 9dd180b to 73e6008 Compare November 9, 2023 07:34
@alexrashed alexrashed merged commit 8889588 into release/v3.0 Nov 9, 2023
@alexrashed alexrashed deleted the remove-legacy-edge-proxy-new branch November 9, 2023 11:17
alexrashed added a commit that referenced this pull request Nov 9, 2023
@alexrashed
remove legacy edge proxy and generic proxy (#9581)
74c336c
@whummer whummer mentioned this pull request Nov 10, 2023
Merged
@alexrashed alexrashed mentioned this pull request Nov 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikschubert dominikschubert dominikschubert approved these changes

@bentsku bentsku bentsku approved these changes

@pinzon pinzon Awaiting requested review from pinzon

@simonrw simonrw Awaiting requested review from simonrw

@thrau thrau Awaiting requested review from thrau

@whummer whummer Awaiting requested review from whummer

@dfangl dfangl Awaiting requested review from dfangl

@MEPalma MEPalma Awaiting requested review from MEPalma

@baermat baermat Awaiting requested review from baermat

@viren-nadkarni viren-nadkarni Awaiting requested review from viren-nadkarni

@macnev2013 macnev2013 Awaiting requested review from macnev2013

@silv-io silv-io Awaiting requested review from silv-io

@steffyP steffyP Awaiting requested review from steffyP

@joe4dev joe4dev Awaiting requested review from joe4dev

@sannya-singal sannya-singal Awaiting requested review from sannya-singal

@calvernaz calvernaz Awaiting requested review from calvernaz

@HarshCasper HarshCasper Awaiting requested review from HarshCasper

@giograno giograno Awaiting requested review from giograno

Assignees

@alexrashed alexrashed

Labels
semver: major Breaking changes which can be included in a major release only
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@alexrashed @coveralls @dominikschubert @bentsku