Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix SQS JSON leftovers #9607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 13, 2023
Merged

fix SQS JSON leftovers #9607

merged 6 commits into from
Nov 13, 2023

Conversation

bentsku
Copy link
Contributor

@bentsku bentsku commented Nov 11, 2023

Motivation

To quickly merge the changes, the PR comments of #8268 had not been addressed yet. This PR does the second iteration.

Changes

  • remove a debug print statement and fix a typo
  • add a comment regarding the conflict resolution between sqs and sqs-query service names, might need to create a specific step in the service name parser resolution if more services start to migrate to the json protocol, based on Content-Type header?
  • add sqs-query as a dependency of SQS in the API dependencies for SERVICES, so that we enable both in case sqs is enabled.

TODO

What's left to do:

  • keep an eye on boto/botocore@50861b9, which will be in release >1.31.84 (not yet released then), which explains this change in the previous PR:
    -        with pytest.raises(aws_client.sqs.exceptions.QueueNameExists):
    +        with pytest.raises(ClientError) as e:
    (I don't think it would change anything in snapshot but we can verify then)

@bentsku bentsku added aws:sqs Amazon Simple Queue Service area: asf semver: patch Non-breaking changes which can be included in patch releases labels Nov 11, 2023
@bentsku bentsku added this to the 3.0 milestone Nov 11, 2023
@coveralls
Copy link

coveralls commented Nov 11, 2023

Coverage Status

coverage: 83.995% (-0.02%) from 84.011%
when pulling 7d14779 on fix-sqs-json-next
into d4933e0 on master.

Copy link

github-actions bot commented Nov 11, 2023

LocalStack Community integration with Pro

       2 files         2 suites   1h 19m 11s ⏱️
2 308 tests 2 010 ✔️ 298 💤 0
2 309 runs  2 010 ✔️ 299 💤 0

Results for commit 7d14779.

♻️ This comment has been updated with latest results.

@bentsku bentsku mentioned this pull request Nov 13, 2023
13 tasks
@alexrashed alexrashed linked an issue Nov 13, 2023 that may be closed by this pull request
1 task
@bentsku bentsku marked this pull request as ready for review November 13, 2023 12:33
Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: asf aws:sqs Amazon Simple Queue Service semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: SQS createQueue fails with Service sqs-query is not enabled
3 participants