-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
fix SQS JSON leftovers #9607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
fix SQS JSON leftovers #9607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
1 task
1 task
alexrashed
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹
fd1c226
to
7d14779
Compare
1 task
Merged
9 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: asf
aws:sqs
Amazon Simple Queue Service
semver: patch
Non-breaking changes which can be included in patch releases
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To quickly merge the changes, the PR comments of #8268 had not been addressed yet. This PR does the second iteration.
Changes
sqs
andsqs-query
service names, might need to create a specific step in the service name parser resolution if more services start to migrate to thejson
protocol, based onContent-Type
header?sqs-query
as a dependency of SQS in the API dependencies forSERVICES
, so that we enable both in casesqs
is enabled.TODO
What's left to do: