update ASF APIs, fix SQS serialization #9611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalStack Community integration with Pro 2 files ±0 2 suites ±0 1h 19m 9s ⏱️ + 10m 58s Results for commit 4fa3c90. ± Comparison against base commit 9dc7713. This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
a8b3536 to
49b84a7
Compare
|
Test run in ext validating SQS changes: 6850081041 |
alexrashed
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
Thanks @bentsku for jumping on this last piece to get the JSON protocol changes in SQS over the line! 🦸🏽
|
-ext tests are green! just waiting for the last one in CircleCI and we can merge. |
|
The failing tests are flakes, everything else is green (and the tests were successful in another run), so I'll move forward and merge this one. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR started out as a regular automatically created ASF Update PR, but it contains some crucial changes in the SQS specs related to #8268 and #8267.
These recent changes in
botocorehave quite an impact on the generated ASF API stubs (see the first commit in this PR).These changes need to be addressed in the SQS serializers to make sure that the responses (especially the error codes) are serialized properly.
Changes
IntegertoNullableInteger, even though within the shape itself is not nullable, the presence of the field is optional).