-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
refresh sqs snapshots and fix exceptions in serializer #9627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bentsku |
@dominikschubert good point, I didn't think about the auto-use, it makes a lot of sense! Or maybe something at the "save" time, if there are no keys and the dict is empty, we could maybe not create an entry in the file? That might be simpler. Let's see after v3, this is extremely minor 😄 thanks for the response! |
Motivation
Following botocore update regarding exception handling of SQS (introduced in boto/botocore#3054, released with 1.31.85), we needed to refresh snapshots for the newly added field.
It put into light some changes regarding error codes, so I've adapted the exceptions raised and their mapping in the serializer.
It also showed that the error message is different for
QueueDoesNotExist
depending onquery
orjson
protocol, put into light with a new snapshot test.Changes
Error
andQueryErrorCode
)only_localstack
so that we don't run those tests against AWS. I believe one nice step also would be to not create a snapshot entry in the json file if the test does not have the snapshot fixture, I'm sure we could detect that? @dominikschubertconnect_to
in the query API to usesqs_query
client