fix change_message_visibility behaviour for expired handles #9632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey just a note - my original report was on a message that I just pulled - the handle was not expired |
bentsku
approved these changes
Nov 14, 2023
No I do not, it might simply be an unused remnant in the api |
|
…uccess without changes
611381e to
8326abc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Customer reported an error when changing message visibility. This most likely comes from a discrepancy between AWS and us when calling
change_message_visibility.Fixes #9598
Changes
change_message_visibilityon an already expired handle, where AWS simply sends back an OK and does nothing while we returned an error.