Fix edge port usages #9633
Merged
Fix edge port usages #9633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2ca4401 to
67a693c
Compare
joe4dev
commented
Nov 14, 2023
joe4dev
commented
Nov 14, 2023
67a693c to
edda81a
Compare
simonrw
approved these changes
Nov 14, 2023
tests/aws/services/lambda_/functions/common/endpointinjection/go/src/main.go
Show resolved
Hide resolved
Remove unnecessary default parameter Co-authored-by: Simon Walker <[email protected]>
82ca1eb to
d8ccd20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #9600
Motivation
We previously removed the write-usage of
EDGE_PORTbut kept read-access (e.g.,config.EDGE_PORT) in our codebase. Given the many occurrences, it was easy to miss a few write-usages, and read-access gets mixed up with internal vs. external access.I just noticed some of these issues while reviewing #9600
Changes
This PR fixes these inconsistencies by migrating all usages.
EDGE_PORTwrite usages we previously missedEDGE_PORTusages migrating them to the new networking APILOCALSTACK_HOSTNAMEandEDGE_PORTin Lambda functions toAWS_ENDPOINT_URL. They are functionally equivalent.Testing
I have already run the full pipeline with these changes on top of the commits from #9600 All tests were green except for one flake in community
test_firehose_kinesis_to_s3. Subsequently, I rebased upon master for a clean PR view.