fix SQS json requests sent to query route #9634
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As reported in #8267 (comment), it seems the PHP SDK still struggles to communicate with LocalStack.
After investigation, it showed that the PHP SDK is still sending the requests to the queue URL even though the specs are specifying that it should be against
/
. Our router caught the request and assumed it was a Query API.Changes
Content-Type
header isapplication/x-amz-json-1.0
, raiseNotFound
in the route so that the handler chain can take of the requestTested with a PHP sample, it solves the issue now
Testing
To test the changes with the PHP SDK:
docker pull php
docker run --rm -it php bash
curl -sS https://getcomposer.org/installer | php -- --install-dir=/usr/local/bin --filename=composer
apt update
apt install zip
cd /usr/src
&mkdir app
&cd app
composer require aws/aws-sdk-php
test.php
:export AWS_ACCESS_KEY_ID=test
export AWS_SECRET_ACCESS_KEY=test
php test.php