Thanks to visit codestin.com
Credit goes to github.com

Skip to content

pin opensearch-py < 2.4 #9655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 15, 2023
Merged

pin opensearch-py < 2.4 #9655

merged 1 commit into from
Nov 15, 2023

Conversation

bentsku
Copy link
Contributor

@bentsku bentsku commented Nov 15, 2023 •
edited
Loading

Motivation

It seems botocore just released a minor version containing their service-2.json files now gzip.

Our loader should work, but it seems Moto is directly trying to load them manually and this fails.
One of the stack trace:

.venv/lib/python3.11/site-packages/moto/emr/responses.py:61: in ElasticMapReduceResponse
    aws_service_spec = AWSServiceSpec("data/emr/2009-03-31/service-2.json")
.venv/lib/python3.11/site-packages/moto/core/responses.py:964: in __init__
    spec = load_resource("botocore", path)
.venv/lib/python3.11/site-packages/moto/utilities/utils.py:22: in load_resource
    return json.loads(pkgutil.get_data(package, resource))  # type: ignore
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

Changes

  • bin botocore to be above SQS changes, but under the gzip changes. This doesn't affect us until the next ASF updates.
  • also pin opensearch-py which made an update and now try to import a library that is only in the extra_requires (aiohttp)

@bentsku bentsku self-assigned this Nov 15, 2023
@bentsku bentsku added semver: patch Non-breaking changes which can be included in patch releases area: dependencies Pull requests that update a dependency file labels Nov 15, 2023
dominikschubert
dominikschubert approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for investigating and fixing this so quickly

@bentsku bentsku force-pushed the pin-botocore-before-gzip branch from f24ff12 to 0665724 Compare November 15, 2023 22:36
@bentsku bentsku merged commit b2b3230 into master Nov 15, 2023
@bentsku bentsku deleted the pin-botocore-before-gzip branch November 15, 2023 22:37
@bentsku bentsku changed the title pin botocore before gzip of services pin opensearch-py < 2.4 Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikschubert dominikschubert dominikschubert approved these changes

Assignees

@bentsku bentsku

Labels
area: dependencies Pull requests that update a dependency file semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bentsku @dominikschubert