Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add NodeJS 20 support for Lambda #9659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

ataylorme
Copy link
Contributor

Motivation

I am upgrading my Lambdas to NodeJS 20, which is now supported by AWS, as it is the current LTS version and want to test them with localstack

Changes

Adds NodeJS 20 support for Lambda

Testing

I was unable to test locally. I will spend more time on my local environment but any help testing and updating snapshots is appreciated

TODO

  • update test snapshots
  • update documentation

@localstack-bot
Copy link
Contributor

localstack-bot commented Nov 16, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

Copy link
Contributor

@localstack-bot localstack-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to LocalStack! Thanks for raising your first Pull Request and landing in your contributions. Our team will reach out with any reviews or feedbacks that we have shortly. We recommend joining our Slack Community and share your PR on the #community channel to share your contributions with us. Please make sure you are following our contributing guidelines and our Code of Conduct.

@ataylorme
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@joe4dev
Copy link
Member

joe4dev commented Nov 22, 2023

Thank you @ataylorme for the initiative 👏👏👏 and @DavidTanner for the proactive review comment 👍

Some comments:

  • The API stubs in the __init__.py are automatically generated by our framework AWS Server Framework (ASF) and should not be edited manually. We have a nice blog post that summarizes ASF and snapshot-based parity testing: https://blog.localstack.cloud/2022-08-04-parity-explained/
  • As you pointed out correctly, the snapshot and documentation need to be updated. Updating the snapshots is key for parity.
  • We have experienced inconsistencies around runtime updates in the past (even ourselves) leading to bugfixes (e.g., related to layers validating compatible runtimes) after adding a new runtime.
  • We also have another community PR for adding the new Java 21 runtime Support Java21 in Lambda #9685. Adding all new runtimes in one go makes it easier to update the snapshots at once.

Therefore, we decided to improve the organization of runtimes to allow easier and faster updates in the future. We have prepared this PR #9697

I hope this is ok for you @ataylorme. I can add you as a co-author once I merge the PR for proper credits 🥇 .

We are looking forward to supporting new runtimes much easier and faster in the future 🚀

@ataylorme
Copy link
Contributor Author

@joe4dev thank you for the detailed response. The more organized, single PR absolutely makes sense. I’m looking forward to it shipping in an upcoming release. Cheers!

@ataylorme ataylorme closed this Nov 23, 2023
@joe4dev
Copy link
Member

joe4dev commented Nov 23, 2023

@ataylorme You are welcome :)

The latest image is already out and the next tagged patch release will be published very soon (ETA: tomorrow).

Congratulations on your first LocalStack contribution 🥳

@ataylorme ataylorme deleted the lambda-node20 branch November 28, 2023 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants