Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(5.0): Collection of fixes, mostly due to upgrading DD version #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 16, 2023
Merged

fix(5.0): Collection of fixes, mostly due to upgrading DD version #47

merged 8 commits into from
Nov 16, 2023

Conversation

Pive01
Copy link
Collaborator

@Pive01 Pive01 commented Nov 6, 2023 •
edited
Loading

This PR adds the following fixes:

  • Fixes app bar, with the new version of DD it renders a default height of 41px , changed to auto
  • Fixes status page showing as list instead of grid: not sure why but the style in the class is not picked up as first in order of importance so adding display: grid in the style parameter renders it correctly
  • Added auth token support and using it as default authentication method
  • Fixed problem of Start button not working if you have an image with no tag (so built it yourself)
  • Removed EXTRA_CORS_ALLOWRD_ORIGINS as default env var when starting LS from the extension

Images

image

Screenshot from 2023-11-15 11-17-49

Closes #48

@Pive01 Pive01 requested review from lukqw and HarshCasper November 6, 2023 14:49
lukqw
lukqw approved these changes Nov 16, 2023
View reviewed changes
ui/src/components/Views/Configs/SettingsForm.tsx Outdated
Comment on lines 178 to 179
In order to start the Pro container, add a configuration with the variable LOCALSTACK_AUTH_TOKEN
set to your auth token and select that configuration in the top right corner
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are still supporting auth tokens, so this should probably mentioned API Keys as well, i.e.

API Keys are also supported, but will be deprecated in the future

@Pive01 Pive01 merged commit 52bd9c0 into main Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukqw lukqw lukqw approved these changes

@HarshCasper HarshCasper Awaiting requested review from HarshCasper

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LocalStack extension dashboard UI is broken
2 participants
@Pive01 @lukqw