fix(OS response): Fixed issue with http response format on different OS #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukqw
approved these changes
Jun 13, 2025
There was a problem hiding this comment.
Thanks for being so diligent about improving the experience for all our users.
One of the things I'm thinking is that we might (at some point) benefit from introducing os-specific tests that ensure we're not breaking functionality.
Nothing to act on right now, but curious to get your thoughts on this as well.
|
Yeah I looked into them but apparently they support only for MacOS https://docs.docker.com/extensions/extensions-sdk/dev/continuous-integration/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turned out that the response received from the backend was in a different format based on the OS, on my machine (linux) it returned the raw http response (so with status code etc), while on colleagues laptop (MacOs 15.5) it returned already the data part of the http response...this PR unifies the 2 cases into 1 so we can have it consistent