Add util function to enable transparent local boto3 endpoints #40
Conversation
4547b11 to
6422d40
Compare
90b0bd0 to
58df392
Compare
| "mwaa": "{proto}://{host}:4642", | ||
| "fis": "{proto}://{host}:4643", | ||
| "meteringmarketplace": "{proto}://{host}:4644", | ||
| "transcribe": "{proto}://{host}:4566", | ||
| } | ||
|
|
||
| # TODO remove service port mapping above entirely |
There was a problem hiding this comment.
I feel like we should be able to remove these already right?
There was a problem hiding this comment.
Yes! Great catch - planning to do that in a follow-up version (should not have a functional impact at this stage, but just to separate changes and versions a bit). 👍
| @pytest.fixture(scope="session", autouse=True) | ||
| def startup_localstack(): | ||
| subprocess.check_output(["localstack", "start", "-d"]) | ||
| subprocess.check_output(["localstack", "wait"]) | ||
|
|
||
| yield | ||
|
|
||
| subprocess.check_output(["localstack", "stop"]) |
There was a problem hiding this comment.
any particular reason for using this instead of the localstack python module? 🤔
There was a problem hiding this comment.
Not really, good point - basically just migrated that from the old nosetest setup. Will keep a note for a follow-up iteration 👌
|
|
||
| # create default client, requests should fail | ||
| with pytest.raises(Exception): | ||
| boto3.client("s3").list_buckets() |
There was a problem hiding this comment.
This won't fail if the AWS credentials are set in the environment though.
Could make this more robust by manually specifying access key id & secret
| # skip adding host prefixes, to avoid making requests to, e.g., http://data-localhost:4566 | ||
| is_sd = operation_model.service_model.service_name == "servicediscovery" | ||
| if is_sd and result == "data-": | ||
| return None | ||
| if operation_model.service_model.service_name == "mwaa" and result == "api.": | ||
| return None | ||
| return result |
There was a problem hiding this comment.
stepfunctions has a similar prefix AFAIK (sync-)
There was a problem hiding this comment.
Thanks for the comments @dominikschubert , great points - will pick those up in a follow-up iteration, specifically when we get rid of the obsolete service ports 🧹
enable_local_endpointsutility function to enable transparent local boto3 endpointsdisable_local_endpointscan be used to undo the patchespytest, add code linter/formatter1.38(released version1.37separately to get the AWS Transcribe endpoint change out)TODO: