document --stack option for CLI
#86
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 PR Preview has been successfully built and deployed to https://localstack-snowflake-docs-preview-pr-86.surge.sh 🎊 |
mmaureenliu
reviewed
Jun 17, 2025
| @@ -44,12 +44,12 @@ jobs: | |||
| run: | |||
| docker pull localstack/snowflake:latest & | |||
| pip install localstack | |||
| IMAGE_NAME=localstack/snowflake localstack start -d | |||
| localstack start --stack snowflake | |||
There was a problem hiding this comment.
The original command starts in detached mode while the new command is without the -d flag - is it deliberate or omission?
| @@ -70,11 +70,11 @@ jobs: | |||
| command: | | |||
| pip3 install localstack | |||
| docker pull localstack/snowflake | |||
| IMAGE_NAME=localstack/snowflake localstack start -d | |||
| localstack start --stack snowflake | |||
| @@ -108,7 +108,7 @@ test: | |||
| - docker pull localstack/snowflake:latest | |||
| - dind_ip="$(getent hosts docker | cut -d' ' -f1)" | |||
| - echo "${dind_ip} localhost.localstack.cloud " >> /etc/hosts | |||
| - DOCKER_HOST="tcp://${dind_ip}:2375" IMAGE_NAME=localstack/snowflake localstack start -d | |||
| - DOCKER_HOST="tcp://${dind_ip}:2375" localstack start --stack snowflake | |||
gtsiolis
approved these changes
Jun 17, 2025
There was a problem hiding this comment.
Thanks for trying this CLI option, @HarshCasper!
LGTM, also agree on keeping the detached -d option in the three instances as @mmaureenliu mentioned above[1].
The stacks terminology is still shaping, but it's in the right path. CLI has the --stack option, and the console will have a new Stacks section[2] in the main navigation on the next deployment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.