Fix cloneDeep Map key cloning#6229
Open
puneetdixit200 wants to merge 1 commit into
Open
Conversation
ljharb
requested changes
Jun 5, 2026
ljharb
left a comment
Member
There was a problem hiding this comment.
this is a breaking change; we can't do it by default.
Ap-0007
reviewed
Jun 7, 2026
Ap-0007
left a comment
There was a problem hiding this comment.
Great fix! Cloning the keys in a Map is essential for a true deep clone, especially since Map keys are often complex objects themselves. The test cases clearly demonstrate the issue and the fix. Looks solid to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6228.
Summary
Checks
HEADreused the Map key/nested object (true true), patched build clones both and preserves the old nested value (false false 1)npm run style:mainnpm run test:main(6,828 passing, 0 failing)git diff --checkNotes
npm run style:testand directjscs test/test.jswere attempted, but the legacy JSCS process did not complete locally under Node v24.15.0.