Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: publishing app not building #10911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 24, 2024
Merged

fix: publishing app not building #10911

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
31e9769
fix: publishing not loading correctly
logseq-cldwalker Jan 23, 2024
64f45de
enhance: add a --dev mode to publishing that pairs with shadow's watch
logseq-cldwalker Jan 22, 2024
bd4e4bc
enhance: publishing --dev also watches frontend
logseq-cldwalker Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: publishing not loading correctly 
Caused by pulling in the new component system. Fixes #10893
  • Loading branch information
@logseq-cldwalker
logseq-cldwalker committed Jan 23, 2024
commit 31e97698eb97643d4681f9fba6a81b8176c726c7
3 changes: 3 additions & 0 deletions deps/publishing/src/logseq/publishing/html.cljs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,9 @@ necessary db filtering"
}
}(window.location))"]
;; TODO: should make this configurable
[:script {:src "static/js/react.production.min.js"}]
[:script {:src "static/js/react-dom.production.min.js"}]
[:script {:src "static/js/ui.js"}]
[:script {:src "static/js/main.js"}]
[:script {:src "static/js/interact.min.js"}]
[:script {:src "static/js/highlight.min.js"}]
Expand Down
8 changes: 7 additions & 1 deletion shadow-cljs.edn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,13 @@

:publishing {:target :browser
:module-loader true
:js-options {:ignore-asset-requires true}
:js-options {;; handle `require(xxx.css)`
:ignore-asset-requires true
:resolve {"react" {:target :global
:global "React"}
"react-dom" {:target :global
:global "ReactDOM"}}}

:modules {:main
{:init-fn frontend.publishing/init}
:code-editor
Expand Down