fix: skip editor autopair during native IME keydown - #13193
Draft
tiensonqin wants to merge 2 commits into
Draft
Conversation
Window keydown/keyup listeners pass native KeyboardEvents, but the editor checked composing via goog-event-is-composing?, which only works on goog-wrapped events. That let Japanese IME `[` → 「 be swallowed by [] autopair (#12966). Co-authored-by: Tienson Qin <[email protected]>
Co-authored-by: Tienson Qin <[email protected]>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12966
Problem
Editor
keydown/keyuplisteners are attached with nativewindow.addEventListener, but composing checks usedgoog-event-is-composing?, which only works on goog-wrapped events. Native IME events (isComposing/keyCode229 /Process) were treated as non-composing, so[autopair calledpreventDefaultand inserted[], swallowing Japanese IME「(and similar auto-paired keys).Fix
native-event-is-composing?inkeydown-not-matched-handlerandkeyup-handler.native-event-is-composing?aninclude-process?arity so keyup can keepisComposing-only filtering while still detecting IME process keys where needed.Evidence
[+keyCode229 /isComposingincorrectly inserted[].[still autopairs.:appREPL:native-event-is-composing?detects native IME events;goog-event-is-composing?returnsnilfor the same events.Tests
frontend.handler.editor-test/keydown-not-matched-handler-skips-bracket-autopair-during-imefrontend.util-test/native-event-is-composing?-detects-ime-process-enterManual Japanese IME UI verification was not available here (no Japanese input source).