Add globalization #178
Merged
Add globalization #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
63 tasks
59f97ed to
d6eb119
Compare
| .idea | ||
| !intl/ | ||
| intl/* | ||
| !intl/en/ |
Contributor
There was a problem hiding this comment.
I would use two lines. Please see : https://github.com/strongloop-internal/loopback-knowledge-base/pull/51/files
Contributor
There was a problem hiding this comment.
Nitpick: We usually leave one blank line at the end of file.
Contributor
|
only one comment about wrapping |
lib/mysql.js
Outdated
|
|
||
| if (operatorValue.multiline) | ||
| console.warn('MySQL regex syntax does not respect the `m` flag'); | ||
| g.warn('{{MySQL}} regex syntax does not respect the {{`m`}} flag'); |
Contributor
|
@0candy reviewed; added a bunch of nitpicks... I leave it to you to address them or leave them as it is now |
fe72d6a to
b8d0858
Compare
|
|
||
| var g = require('strong-globalize')(); | ||
|
|
||
| var async = require('async'); |
Contributor
There was a problem hiding this comment.
Nitpick: What is this extra line between variables?
Contributor
|
Two minor comments which feel free to ignore. code changes LGTM. Please check CI tests. |
intl/en/messages.json
Outdated
| "610db3e4d1e877d985000ed09fb01fb9": "callback should be a function", | ||
| "a354e762822e356af4bfa3299fd29b0a": "{{MySQL}} regex syntax does not respect the {{`g`}} flag", | ||
| "cecffcfbf707d97548dcd5859c80b171": "{{MySQL}} regex syntax does not respect the {{`i`}} flag", | ||
| "d230064cbc14fe9bfcf2fb2072c16fb2": "{{MySQL}} regex syntax does not respect the {{`m`}} flag" |
Contributor
There was a problem hiding this comment.
you forgot to to do slt-globalize -e and slt-globalize -l to update this file?
Contributor
|
@slnode test please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strongloop/loopback#2422