Add support for globalization #38
Conversation
7865647 to
8a95121
Compare
| var m = findMethod(this.client, method); | ||
| if(!m) { | ||
| throw new Error('Method not found in WSDL port types: ' + m); | ||
| throw new Error(g.f('Method not found in {{WSDL}} port types: %s', m)); |
There was a problem hiding this comment.
You have to run slt-globalize -e again for intl/en/messages.json to get updated with the brackets change.
There was a problem hiding this comment.
@0candy Done, pushed the changes. Thanks!
f5cd295 to
0086c04
Compare
|
@superkhau @0candy Also I changed |
| node_modules | ||
| !intl/ | ||
| intl/* | ||
|
|
There was a problem hiding this comment.
Missing this line? !intl/en/
eb0ae3d to
2e23d54
Compare
|
@0candy Fixed now. PTAL. Thanks! |
| node_modules | ||
| !intl/en/ | ||
| intl/* | ||
|
|
There was a problem hiding this comment.
There should be 3 lines
!intl/
intl/*
!intl/en/
There was a problem hiding this comment.
But your comment in my loopback-datasource-juggler PR, says we can get rid of !intl/, no?
Does it work without this line? !intl/
And in fact it works
There was a problem hiding this comment.
I m not sure who originally decided the three line's standard, but if the original decider requires three, then probably we should keep !intl/.
ATM i think the only difference is if a repo doesn't have folder en, !intl makes sure the intl folder(empty in this case) still exist in that repo
There was a problem hiding this comment.
There was a problem hiding this comment.
I m not sure who originally decided the three line's standard, but if the original decider requires three, then probably we should keep !intl/.
ATM i think the only difference is if a repo doesn't have folder en, !intl makes sure the intl folder(empty in this case) still exist in that repo
@0candy Tested this in her initial run and @Amir-61 found out you don't need the first line. Hence the update in globalization.md PR. These are nitpicks if you already have those lines in your files anyways. It's up to you since you're the repo owner whether you want to address them now or in the future or if ever. This won't stop your PR from getting the green light.
|
@Amir-61 LGTM 👍 |
/to: @0candy PTAL