Backport globalization #1029
Merged
Backport globalization #1029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
For now I have not squashed into one commit; I can do it if you think it is necessary after review. |
lib/dao.js
Outdated
| } | ||
| } else { | ||
| err = new Error(util.format('The order %j is not valid', order[i])); | ||
| err = new Error('The order %j is not valid', order[i]); |
lib/include.js
Outdated
| if (!relation.polymorphic) { | ||
| cb(new Error('Relation.modelTo is not defined for relation' + | ||
| relationName + ' and is no polymorphic')); | ||
| cb(new Error(g.f('{{Relation.modelTo}} is not defined for relation %s and is no polymorphic', |
Contributor
|
LGTM, only two comments 👍 |
package.json
Outdated
| "loopback-connector": "^2.1.0", | ||
| "node-uuid": "^1.4.2", | ||
| "qs": "^3.1.0", | ||
| "strong-globalize": "^2.6.0", |
Contributor
|
@Amir-61 Two comments, otherwise LGTM. |
Contributor
|
@Amir-61 Please squash before merging too. |
lib/datasource.js
Outdated
| // The connection fails, let's report it and hope it will be recovered in the next call | ||
| console.error('Connection fails: ', err, '\nIt will be retried for ' + | ||
| 'the next request.'); | ||
| console.error(g.f('Connection fails: %s\nIt will be retried for the next request.', err)); |
Contributor
There was a problem hiding this comment.
just use g.error instead of console.error(g.f
Merged
225676f to
642838b
Compare
63 tasks
Contributor
Author
|
Thanks for reviewing! 🙇 I applied your feedback and I'm going to land it after checking CI. Thanks! |
642838b to
6debb50
Compare
Backport loopback-datasource-juggler#1022, loopback-datasource-juggler#1024, loopback-datasource-juggler#1026
bdae2a8 to
9da0e50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting these 3 PRs of globalization:
#1022
#1024
#1026
This backporting needs very careful review since there were tons of merge conflicts and there is a possibility of doing something wrong!
I would like to get LGTM from @superkhau @0candy @jannyHou individually to make sure everything looks good and merge conflicts have been solved safely.
Thanks a lot!