This repository was archived by the owner on Sep 28, 2023. It is now read-only.
Use Twig namespace instead of old colon-separated syntax#7
Merged
Conversation
Contributor
|
Hi @danabrey, thank you for your PR! |
Contributor
Author
|
No problem @ghidosoft, this bundle saved us a good few hours today! I've created a Flex recipe for the bundle and submitted a pull request here: symfony/recipes-contrib#352 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old-style colon-separated syntax is only supported in Symfony 4 if the
symfony/templatingcomponent is installed. Moreover, overriding templates doesn't work if they're defined using this syntax.Switching to Twig namespace (automatically created for bundles since SF2.7) fixes both of these issues.