remove auto_tiles option

jcupitt · jcupitt · commit 2de901868f04 · 2024-10-12T13:30:38.000+01:00
just turn it on by default see libvips#4191 (comment)
diff --git a/ChangeLog b/ChangeLog
@@ -25,7 +25,6 @@
 - add "unpack_complex" option to vips_getpoint()
 - add deflate compression level setting to tiffsave [ruven]
 - add "smart_deblock" to webpsave [goodusername123]
-- add "auto_tiles" to heifsave [lovell]
 
 4/10/24 8.15.5
 
diff --git a/libvips/foreign/foreign.c b/libvips/foreign/foreign.c
@@ -2366,7 +2366,6 @@ vips_heifload_source(VipsSource *source, VipsImage **out, ...)
  * * @effort: %gint, encoding effort
  * * @subsample_mode: #VipsForeignSubsample, chroma subsampling mode
  * * @encoder: #VipsForeignHeifEncoder, select encoder to use
- * * @auto_tiles: %gboolean, determine optimum tile count
  *
  * Write a VIPS image to a file in HEIF format.
  *
@@ -2390,11 +2389,6 @@ vips_heifload_source(VipsSource *source, VipsImage **out, ...)
  *
  * Use @encoder to set the encode library to use, e.g. aom, SVT-AV1, rav1e etc.
  *
- * When using the aom encoder, set @auto_tiles to determine the optimum
- * number of tiles based on dimensions and available threads. This can
- * improve multi-core utilisation and/or reduce peak memory consumption
- * at the expense of slightly increased file size.
- *
  * See also: vips_image_write_to_file(), vips_heifload().
  *
  * Returns: 0 on success, -1 on error.
@@ -2428,7 +2422,6 @@ vips_heifsave(VipsImage *in, const char *filename, ...)
  * * @effort: %gint, encoding effort
  * * @subsample_mode: #VipsForeignSubsample, chroma subsampling mode
  * * @encoder: #VipsForeignHeifEncoder, select encoder to use
- * * @auto_tiles: %gboolean, determine optimum tile count
  *
  * As vips_heifsave(), but save to a memory buffer.
  *
@@ -2483,7 +2476,6 @@ vips_heifsave_buffer(VipsImage *in, void **buf, size_t *len, ...)
  * * @effort: %gint, encoding effort
  * * @subsample_mode: #VipsForeignSubsample, chroma subsampling mode
  * * @encoder: #VipsForeignHeifEncoder, select encoder to use
- * * @auto_tiles: %gboolean, determine optimum tile count
  *
  * As vips_heifsave(), but save to a target.
  *
diff --git a/libvips/foreign/heifsave.c b/libvips/foreign/heifsave.c
@@ -130,10 +130,6 @@ typedef struct _VipsForeignSaveHeif {
 	 */
 	int speed;
 
-	/* Auto tiles (currently aom only).
-	*/
-	gboolean auto_tiles;
-
 } VipsForeignSaveHeif;
 
 typedef VipsForeignSaveClass VipsForeignSaveHeifClass;
@@ -652,8 +648,11 @@ vips_foreign_save_heif_build(VipsObject *object)
 	}
 #endif /*HAVE_HEIF_ENCODER_PARAMETER_GET_VALID_INTEGER_VALUES*/
 
+	/* Try to enable auto_tiles. This can make AVIF encoding a lot faster,
+	 * with only a very small increase in file size.
+	 */
 	error = heif_encoder_set_parameter_boolean(heif->encoder,
-		"auto-tiles", heif->auto_tiles);
+		"auto-tiles", TRUE);
 	if (error.code &&
 		error.subcode != heif_suberror_Unsupported_parameter) {
 		vips__heif_error(&error);
@@ -819,13 +818,6 @@ vips_foreign_save_heif_class_init(VipsForeignSaveHeifClass *class)
 		G_STRUCT_OFFSET(VipsForeignSaveHeif, selected_encoder),
 		VIPS_TYPE_FOREIGN_HEIF_ENCODER,
 		VIPS_FOREIGN_HEIF_ENCODER_AUTO);
-
-	VIPS_ARG_BOOL(class, "auto_tiles", 19,
-		_("Auto-tiles"),
-		_("Determine optimum tile count"),
-		VIPS_ARGUMENT_OPTIONAL_INPUT,
-		G_STRUCT_OFFSET(VipsForeignSaveHeif, auto_tiles),
-		FALSE);
 }
 
 static void

Original file line number	Diff line number	Diff line change
`@@ -2366,7 +2366,6 @@ vips_heifload_source(VipsSource source, VipsImage *out, ...)`
`2366`	`2366`	`* * @effort: %gint, encoding effort`
`2367`	`2367`	`* * @subsample_mode: #VipsForeignSubsample, chroma subsampling mode`
`2368`	`2368`	`* * @encoder: #VipsForeignHeifEncoder, select encoder to use`
`2369`		`- * * @auto_tiles: %gboolean, determine optimum tile count`
`2370`	`2369`	`*`
`2371`	`2370`	`* Write a VIPS image to a file in HEIF format.`
`2372`	`2371`	`*`
`@@ -2390,11 +2389,6 @@ vips_heifload_source(VipsSource source, VipsImage *out, ...)`
`2390`	`2389`	`*`
`2391`	`2390`	`* Use @encoder to set the encode library to use, e.g. aom, SVT-AV1, rav1e etc.`
`2392`	`2391`	`*`
`2393`		`- * When using the aom encoder, set @auto_tiles to determine the optimum`
`2394`		`- * number of tiles based on dimensions and available threads. This can`
`2395`		`- * improve multi-core utilisation and/or reduce peak memory consumption`
`2396`		`- * at the expense of slightly increased file size.`
`2397`		`- *`
`2398`	`2392`	`* See also: vips_image_write_to_file(), vips_heifload().`
`2399`	`2393`	`*`
`2400`	`2394`	`* Returns: 0 on success, -1 on error.`
`@@ -2428,7 +2422,6 @@ vips_heifsave(VipsImage in, const char filename, ...)`
`2428`	`2422`	`* * @effort: %gint, encoding effort`
`2429`	`2423`	`* * @subsample_mode: #VipsForeignSubsample, chroma subsampling mode`
`2430`	`2424`	`* * @encoder: #VipsForeignHeifEncoder, select encoder to use`
`2431`		`- * * @auto_tiles: %gboolean, determine optimum tile count`
`2432`	`2425`	`*`
`2433`	`2426`	`* As vips_heifsave(), but save to a memory buffer.`
`2434`	`2427`	`*`
`@@ -2483,7 +2476,6 @@ vips_heifsave_buffer(VipsImage in, void buf, size_t len, ...)`
`2483`	`2476`	`* * @effort: %gint, encoding effort`
`2484`	`2477`	`* * @subsample_mode: #VipsForeignSubsample, chroma subsampling mode`
`2485`	`2478`	`* * @encoder: #VipsForeignHeifEncoder, select encoder to use`
`2486`		`- * * @auto_tiles: %gboolean, determine optimum tile count`
`2487`	`2479`	`*`
`2488`	`2480`	`* As vips_heifsave(), but save to a target.`
`2489`	`2481`	`*`