fix(workflow): Fix argument wrapping in array when signaling from Workflow (temporalio#410)

bergundy · web-flow · commit 043ca15a031e · 2021-11-29T12:15:13.000-06:00
diff --git a/packages/test/src/workflows/child-workflow-signals.ts b/packages/test/src/workflows/child-workflow-signals.ts
@@ -12,7 +12,7 @@ import {
   uuid4,
 } from '@temporalio/workflow';
 import { signalTarget } from './signal-target';
-import { unblockSignal, failWithMessageSignal } from './definitions';
+import { argsTestSignal, unblockSignal, failWithMessageSignal } from './definitions';
 
 /**
  * If this workflow completes successfully, it should make the test pass
@@ -22,6 +22,8 @@ export async function childWorkflowSignals(): Promise<void> {
   {
     // Happy path
     const child = await startChild(signalTarget, {});
+    // Args are transferred correctly
+    await child.signal(argsTestSignal, 123, 'kid');
     await child.signal(unblockSignal);
     await child.result();
   }
@@ -52,6 +54,8 @@ export async function childWorkflowSignals(): Promise<void> {
     // Happy path
     const child = await startChild(signalTarget, {});
     const external = getExternalWorkflowHandle(child.workflowId, child.originalRunId);
+    // Args are transferred correctly
+    await external.signal(argsTestSignal, 123, 'kid');
     await external.signal(unblockSignal);
     await child.result();
   }
diff --git a/packages/test/src/workflows/definitions.ts b/packages/test/src/workflows/definitions.ts
@@ -12,4 +12,5 @@ export interface LoggerSinks extends Sinks {
 export const activityStartedSignal = defineSignal('activityStarted');
 export const failSignal = defineSignal('fail');
 export const failWithMessageSignal = defineSignal<[string]>('fail');
+export const argsTestSignal = defineSignal<[number, string]>('argsTest');
 export const unblockSignal = defineSignal('unblock');
diff --git a/packages/test/src/workflows/signal-target.ts b/packages/test/src/workflows/signal-target.ts
@@ -5,11 +5,17 @@
  * @module
  */
 import { condition, setHandler } from '@temporalio/workflow';
-import { failWithMessageSignal, unblockSignal } from './definitions';
+import { argsTestSignal, failWithMessageSignal, unblockSignal } from './definitions';
 
 export async function signalTarget(): Promise<void> {
   let unblocked = false;
 
+  // Verify arguments are sent correctly
+  setHandler(argsTestSignal, (num, str) => {
+    if (!(num === 123 && str === 'kid')) {
+      throw new Error('Invalid arguments');
+    }
+  });
   setHandler(failWithMessageSignal, (message) => {
     throw new Error(message);
   });
diff --git a/packages/workflow/src/workflow.ts b/packages/workflow/src/workflow.ts
@@ -309,7 +309,7 @@ function signalWorkflowNextHandler({ seq, signalName, args, target }: SignalWork
     state.pushCommand({
       signalExternalWorkflowExecution: {
         seq,
-        args: state.dataConverter.toPayloadsSync(args),
+        args: state.dataConverter.toPayloadsSync(...args),
         signalName,
         ...(target.type === 'external'
           ? {
