Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(workflow): Fix argument wrapping in array when signaling from Workflow #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2021
Merged

fix(workflow): Fix argument wrapping in array when signaling from Workflow #410

merged 1 commit into from
Nov 29, 2021

Conversation

bergundy
Copy link
Member

Apparently argument passing did not have test coverage and the rest argument in the data converter method prevented us from catching this earlier.

Before this fix, signal arguments sent from a workflow would be wrapped in an array.

await child.signal(someSignal, 1, '2');

Was received in the child workflow as:

wf.setHandler(someSignal, (num, str) => {
  console.log(a, b) // [1, '2'], undefined
});

@bergundy bergundy self-assigned this Nov 29, 2021
@bergundy bergundy merged commit 043ca15 into main Nov 29, 2021
@bergundy bergundy deleted the workflow-signal-args branch November 29, 2021 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cretz cretz cretz approved these changes

@Sushisource Sushisource Awaiting requested review from Sushisource

Assignees

@bergundy bergundy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bergundy @cretz