Fix iOS frames being calculated incorrectly#1019
Merged
matinzd merged 2 commits intoMay 4, 2023
Merged
Conversation
matinzd
approved these changes
May 4, 2023
matinzd
left a comment
Member
There was a problem hiding this comment.
Looks good! Thanks for your contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of RC4 (This PR), Lottie no longer wraps the Native component in a separate view, and passes all the view props to the native implementation. This causes an issue with Lottie on iOS, as the iOS version of Lottie is made of two different views:
RCTViewfrom react native that gets all of the props (Like background color, etc)LottieAnimationViewwhich is aSubviewof theRCTViewThe
LottieAnimationViewis tapping into theRCTView'sframeand giving it to itself. But this is incorrect as theframeproperty on iOS has the coordinates of theRCTViewas well, leading to a rather gnarly offset. Instead offrame, theboundsproperty should be used.This PR does three things:
LottieAnimationViewfromframetoboundsand removes the hacky override at the top.NOTE: The reason wrapping the Native component with a view fixed the issue is that the
frameof theRCTViewwould be equal to thebounds, due to the styling being applied to the parent and the fact thatframeis calculated relative to the parent