Improve Discord channel activation and progress display - #292
Merged
Merged
Conversation
lsdefine
approved these changes
May 8, 2026
lsdefine
left a comment
Owner
There was a problem hiding this comment.
LGTM. Per-channel isolation, activation mechanism, and progress display are solid improvements. Minor suggestions for future: abort agent on LRU eviction, and use self._agents.get() in _deactivate_channel to avoid creating a new agent just to abort it.
bendusy
pushed a commit
to bendusy/GenericAgent
that referenced
this pull request
May 14, 2026
RocketLi
pushed a commit
to RocketLi/GenericAgent
that referenced
this pull request
May 18, 2026
lsdefine
pushed a commit
that referenced
this pull request
Jul 23, 2026
Imzl-zl
pushed a commit
to Imzl-zl/GenericAgent
that referenced
this pull request
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the Discord frontend:
<summary>text.