Returning async results no longer marks incorrect czarId as an error.#1027
Merged
Conversation
iagaponenko
approved these changes
Jun 2, 2026
| _messageStore->addErrorMessage("SYSTEM", message); | ||
| return; | ||
| LOGS(_log, LOG_LVL_WARN, | ||
| "UserQueryAsyncResult::submit Query originated from different czar=" << _qInfo.czarId() |
Contributor
There was a problem hiding this comment.
This is not critical. To make the messages immutable for possible changes in the names of the enclosing methods, I use the following pattern:
"UserQueryAsyncResult::" << __func__ << " Query originated from different czar="
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would be very short, except clang-format made unrelated changes. The only changes that matter here are in ccontrol.