Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Updated color functionality#15

Merged
lucharo merged 8 commits intolucharo:mainfrom
siddarth-patil:update_01-color-functionality-
Mar 17, 2021
Merged

Updated color functionality#15
lucharo merged 8 commits intolucharo:mainfrom
siddarth-patil:update_01-color-functionality-

Conversation

@siddarth-patil
Copy link
Contributor

Now random colors will be allocated to the categories for which the color is not specified explicitly. Updated the GIF, Readme, Test_module, and example code as well.

added a optional attribute to "barplot" called "item_color" to give the ability to user to specify their own color if they want to.
Added GIF of the working example with specified colors for categories.
Added the color example with code and GIF under "example directory.

Also updated the readme file with the necessary changes
Added numpy dependancy
Now the colors will be allocated randomly to those categories to which color is not specified explictly.

Updated the ReadMe file, GIF, Tests, and Example Code as well.
@lucharo
Copy link
Owner

lucharo commented Jan 28, 2021

Hi @siddarth-patil thanks for refactoring, there's still a few old commits. I'll take the last commit (the only one containing a change from master) and merge to master over the weekend.

@siddarth-patil
Copy link
Contributor Author

Hi @siddarth-patil thanks for refactoring, there's still a few old commits. I'll take the last commit (the only one containing a change from master) and merge to master over the weekend.

Thanks a lot @lc5415 Is it common to get conflicts? Please let me know what can I do to make sure that there are no conflicts next time.

Also, I read somewhere that it is better to link pull requests to issues. So, should we also follow the same from next time?

Merge branch 'main' into update_01-color-functionality-
@lucharo
Copy link
Owner

lucharo commented Mar 17, 2021

Hi @siddarth-patil, I've finally made some time to take care of this, sorry for the delay.

Looking back, I suspect the problem was I merged your initial PR from the update_01-color-functionality branch and then made some more changes (documentation or whatnot). Then you kept on adding the random-color-if-not-specified feature in your original branch but you didn't take into account the further changes I made in the middle (in that case you should have pulled the changes from my main branch if you wanted to continue from the first branch or simply create another branch/fork from my updated main branch). In general I prefer the latter method where every new feature stems from the latest version of the branching you are submitting a PR into. Though this is very context dependent.

Thanks for your contribution

@lucharo lucharo merged commit 8e17d44 into lucharo:main Mar 17, 2021
@siddarth-patil
Copy link
Contributor Author

Hi @lucharo, thanks a lot. I will take care of these conflicts the next time. Lemme know if there is some other functionality in your mind that could be added to this package, I would like to work on it.

@lucharo
Copy link
Owner

lucharo commented Mar 17, 2021

Ok, great @siddarth-patil, I would recommend closing/deleting your update-colour-functionality branch in your raceplotly fork now and if at some point in the future you think of a new feature you wanna add then you should a create a branch for that specific feature and then later a PR!

@siddarth-patil siddarth-patil deleted the update_01-color-functionality- branch November 6, 2022 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants