Conversation
added a optional attribute to "barplot" called "item_color" to give the ability to user to specify their own color if they want to.
Added GIF of the working example with specified colors for categories.
Added the color example with code and GIF under "example directory. Also updated the readme file with the necessary changes
Added numpy dependancy
Now the colors will be allocated randomly to those categories to which color is not specified explictly. Updated the ReadMe file, GIF, Tests, and Example Code as well.
|
Hi @siddarth-patil thanks for refactoring, there's still a few old commits. I'll take the last commit (the only one containing a change from master) and merge to master over the weekend. |
Thanks a lot @lc5415 Is it common to get conflicts? Please let me know what can I do to make sure that there are no conflicts next time. Also, I read somewhere that it is better to link pull requests to issues. So, should we also follow the same from next time? |
Merge branch 'main' into update_01-color-functionality-
|
Hi @siddarth-patil, I've finally made some time to take care of this, sorry for the delay. Looking back, I suspect the problem was I merged your initial PR from the Thanks for your contribution |
|
Hi @lucharo, thanks a lot. I will take care of these conflicts the next time. Lemme know if there is some other functionality in your mind that could be added to this package, I would like to work on it. |
|
Ok, great @siddarth-patil, I would recommend closing/deleting your |
Now random colors will be allocated to the categories for which the color is not specified explicitly. Updated the GIF, Readme, Test_module, and example code as well.