Fix connection on resume when CONFIG_ANDROID=y #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The partial fix made in commit 2913f99 relies on the fact that during suspend/resume, netdev_close() calls rtw_indicate_disconnect() and that ultimately informs cfg80211 that we have disconnected. However that codepath doesn't run when CONFIG_ANDROID=y, so this bug is effectively back on kernels where that option is set, including current Ubuntu kernels. It's not a complete fix but should keep this codebase hobbling along... Going forward, the newer v5 driver mentioned in lwfinger#144 looks like it should handle this situation much better, as long as RTW_CFG80211_ALWAYS_INFORM_STA_DISCONNECT_EVENT is set, which I'd recommend doing. Signed-off-by: Daniel Drake <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The partial fix made in commit 2913f99 relies on the
fact that during suspend/resume, netdev_close() calls
rtw_indicate_disconnect() and that ultimately informs cfg80211 that
we have disconnected.
However that codepath doesn't run when CONFIG_ANDROID=y, so this bug
is effectively back on kernels where that option is set, including
current Ubuntu kernels.
It's not a complete fix but should keep this codebase hobbling along...
Going forward, the newer v5 driver mentioned in
#144
looks like it should handle this situation much better, as long as
RTW_CFG80211_ALWAYS_INFORM_STA_DISCONNECT_EVENT is set, which
I'd recommend doing.
Signed-off-by: Daniel Drake [email protected]