[DPTOOLS-3012] Cherry-pick fix for FAB actions#234
Conversation
Cherry-pick the upstream fix for FAB actions on models with composite primary keys. See apache@28229e9
Codecov Report
@@ Coverage Diff @@
## airflowinfra #234 +/- ##
================================================
- Coverage 27.82% 27.81% -0.01%
================================================
Files 528 528
Lines 36654 36671 +17
================================================
+ Hits 10198 10200 +2
- Misses 26456 26471 +15
Continue to review full report at Codecov.
|
| isinstance(obj.impl, UtcDateTime) | ||
| return False | ||
|
|
||
| # This is a local fix until https://github.com/dpgaspar/Flask-AppBuilder/pull/1493 is merged and released. |
There was a problem hiding this comment.
Hmm, that comment they mention, that fix is merged and released
There was a problem hiding this comment.
Yea if you update to the latest FAB version, you won't need that
There was a problem hiding this comment.
Cool, thanks - will follow up with a revert + version bump next week
|
π |
|
+1 |
|
Good to see you Tao π |
|
lol |
|
btw, I lost all the airflow commits (https://github.com/apache/airflow) based on (https://github.com/apache/airflow/graphs/contributors). I guess the commit is tied to a given email, since my lyft email is gone, commit history is gone as well... |
|
that's annoying |
You can add your previous email to .mailmap and it would be back :) |
|
TIL Thank you Kaxil. |
|
TIL, thanks @kaxil , let me give a try |
|
@kaxil do you know how to do that ? I found my lyft email is listed in https://github.com/apache/airflow/blob/master/.mailmap#L91 . Anything else to do? |
|
:( Looks like I was wrong based on https://github.community/t/how-to-get-mailmap-to-work-and-record-contributions-in-relevant-users-profile/121285 unfortunately. -- **Github ** does not seem to honor it for contributions graph. Locally it will show all of your emails as a single user with git log |
|
TIL: Always use my personal email for upstream changes |
Cherry-pick the upstream fix for FAB actions on models with composite
primary keys. See
apache@28229e9