Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

venil7
Copy link

@venil7 venil7 commented Dec 10, 2015

added as a 5'th optional parameter to .create method, so to not break backwards compatibility
defaults to ctrl
see readme for details

@dougmoscrop
Copy link
Collaborator

I'm not a big fan of a large number of parameters, like I much prefer an options-argument that gives things names, I realize this already has four parameters but I'm not sure we want to keep that up. I'm interested in what other people think - but I'd prefer to make this part of 'opts'.

@venil7
Copy link
Author

venil7 commented Dec 10, 2015

@dougmoscrop I agree with that, in fact extending opts was my first attempt, before I realized it was solely todo with object<IDialogOptions> - options for dialog

@dougmoscrop
Copy link
Collaborator

yeah, you're right. maybe we can explore, unrelated to this, moving to a single-param options block (some kind of backwards compatible check like arguments.length === 1 && typeof arguments[0] === 'object') to support a new syntax but I'm 👍 on this

@niemyjski
Copy link
Collaborator

Should we create a new issue for this as I would also like an options object as long as we don't break compat or bump the major? I think accepting this is fine. Everyone agree?

@dougmoscrop
Copy link
Collaborator

#159

niemyjski added a commit that referenced this pull request Dec 10, 2015
@niemyjski niemyjski merged commit 58cc8f6 into m-e-conroy:master Dec 10, 2015
@venil7 venil7 deleted the controller-as branch December 10, 2015 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants