This repository was archived by the owner on Nov 19, 2024. It is now read-only.
Update mod_intro.md #1524
Merged
Update mod_intro.md #1524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add <type> - placeholder to module path. Use Customer Import/Export module instead of Customer module to show hyphen using in module name.
jeff-matthews
suggested changes
Nov 2, 2017
| @@ -34,7 +34,7 @@ See <a href="{{page.baseurl}}architecture/archi_perspectives/components/modules/ | |||
|
|
|||
| ## Where do modules live? | |||
|
|
|||
| Modules typically live in the `vendor` directory of a Magento installation, in a directory with the following PSR-0 compliant format: `vendor/<vendor>/module-<module-mame>`. For example, the Customer module of Magento can be found at `vendor/magento/module-customer`. | |||
| Modules typically live in the `vendor` directory of a Magento installation, in a directory with the following PSR-0 compliant format: `vendor/<vendor>/<type>-<module-mame>`. For example, the Customer Import/Export module of Magento can be found at `vendor/magento/module-customer-import-export`. | |||
There was a problem hiding this comment.
<module-mame> should be <module-name>
Also, why replace module with <type>? Doesn't this contradict Magento's module naming convention?
There was a problem hiding this comment.
<type> can be one of values:
- "module" - for modules (
module-customer-import-export); - "theme" - for front and admin themes (
theme-frontend-luma); - "language" - for language packs (
language-de_de);
May be add this info to doc?
There was a problem hiding this comment.
Good point! You're absolutely right. Sorry, I was too focused on the word "module". Yes, I think it would be beneficial to add these to the docs as well. Do you mind adding them?
There was a problem hiding this comment.
Ок, I'll add this info to doc.
Add module type description.
|
Info about module types added. But I have not good English level, therefore you can check it and fix before merging :) |
jeff-matthews
approved these changes
Nov 2, 2017
|
Thanks @likemusic! |
magento-cicd2
pushed a commit
that referenced
this pull request
Dec 6, 2017
Changed Technical Guidelines to be version specific
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add - placeholder to module path. Use Customer Import/Export module instead of Customer module to show hyphen using in module name.