-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Improvements for CSS in responsive design doc #1963
Conversation
…@media-common style group separation. Rearranged sections in document to improve readability, so that things were explained before they were ref.
Hi @rossmc, thanks for adding more info to the topic. On first glance, your change to the content's order helps, but it still feels like the topic is missing information that would make it easier to understand. I'll take a look at this over the next few days. Thanks, again. |
@bdenham yes I agree it can probably improved further. But I think the current doc is missing out on something very important by not mentioning There is more info on it in the Magento UI library documentation Let me know if there is anyway I can help, to rewrite a section or something. |
Thanks, @rossmc. Yes, I completely agree with you on the importance of documenting the |
Any update on this @bdenham, let me know if I can amend in some way to help |
Hey @rossmc, so sorry I had to put this on the back burner for a bit, but I will commit to working with you to complete this before the end of this week! Stay tuned. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, this looks good @rossmc! Thanks for the clarifying writeup.
This PR is a:
[ ] New topic
[✓] Content fix or rewrite
[✓] Bug fix or improvement
Summary
Added more detail on the use of the the
.media-width()
mixin and the@media-common
style group separation.Rearranged sections in document to improve readability, so that things were explained before they were referenced. For instance it's hard to explain how M2 uses media queries in their themes without first explaining their mobile first approach and use of breakpoints
Preview...
