Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Improvements for CSS in responsive design doc #1963

Merged
merged 2 commits into from
Jul 24, 2018
Merged

Improvements for CSS in responsive design doc #1963

merged 2 commits into from
Jul 24, 2018

Conversation

rossmc
Copy link
Contributor

@rossmc rossmc commented May 23, 2018

This PR is a:

[ ] New topic
[✓] Content fix or rewrite
[✓] Bug fix or improvement

Summary

Added more detail on the use of the the .media-width() mixin and the @media-common style group separation.

Rearranged sections in document to improve readability, so that things were explained before they were referenced. For instance it's hard to explain how M2 uses media queries in their themes without first explaining their mobile first approach and use of breakpoints

Preview...

…@media-common style group separation.

Rearranged sections in document to improve readability, so that things were explained before they were ref.
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented May 23, 2018

CLA assistant check
All committers have signed the CLA.

@jeff-matthews jeff-matthews added the Technical Updates to the code or processes that alter the technical content of the doc label May 24, 2018
@bdenham
Copy link
Contributor

bdenham commented Jun 1, 2018

Hi @rossmc, thanks for adding more info to the topic. On first glance, your change to the content's order helps, but it still feels like the topic is missing information that would make it easier to understand. I'll take a look at this over the next few days. Thanks, again.

@rossmc
Copy link
Contributor Author

rossmc commented Jun 8, 2018

@bdenham yes I agree it can probably improved further. But I think the current doc is missing out on something very important by not mentioning .media-width() mixins and the @media-common style group. I've spoken with quite a few devs who have gotten stuck on this when first working with M2.

There is more info on it in the Magento UI library documentation
/pub/static/frontend/Magento/blank/en_US/css/docs/responsive.html

Let me know if there is anyway I can help, to rewrite a section or something.

@rossmc rossmc closed this Jun 8, 2018
@rossmc rossmc reopened this Jun 8, 2018
@magento-engcom-team magento-engcom-team removed the Technical Updates to the code or processes that alter the technical content of the doc label Jun 8, 2018
@bdenham
Copy link
Contributor

bdenham commented Jun 8, 2018

Thanks, @rossmc. Yes, I completely agree with you on the importance of documenting the .media-width() mixins and the @media-common style group and will devote time early next week to work with you to get this merged into production. Thanks again for helping out with this!

@rossmc
Copy link
Contributor Author

rossmc commented Jul 11, 2018

Any update on this @bdenham, let me know if I can amend in some way to help

@bdenham
Copy link
Contributor

bdenham commented Jul 11, 2018

Hey @rossmc, so sorry I had to put this on the back burner for a bit, but I will commit to working with you to complete this before the end of this week! Stay tuned.

@bdenham bdenham changed the base branch from develop to master July 13, 2018 14:13
Copy link
Contributor

@bdenham bdenham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, this looks good @rossmc! Thanks for the clarifying writeup.

@bdenham bdenham merged commit ae535ce into magento:master Jul 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants